Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/format_pt #2039

Merged
merged 2 commits into from
Mar 26, 2019
Merged

feature/format_pt #2039

merged 2 commits into from
Mar 26, 2019

Conversation

JarbasAl
Copy link
Contributor

@JarbasAl JarbasAl commented Mar 6, 2019

Description

adds format_pt functions, nice_time and pronounce_number

also moves stuff to common_data_pt

How to test

unittests are there

Contributor license agreement signed?

CLA [ yes] (Whether you have signed a CLA - Contributor Licensing Agreement

@pep8speaks
Copy link

pep8speaks commented Mar 6, 2019 •
edited

Hello @JarbasAl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-26 12:47:15 UTC

@forslund
Copy link
Collaborator

forslund commented Mar 8, 2019

Seems good. I'm ready to merge this after the pep8 issues are fixed :)

@penrods penrods added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 14, 2019
@forslund forslund merged commit a5f5e46 into MycroftAI:dev Mar 26, 2019
@JarbasAl JarbasAl deleted the feature/format_pt branch March 27, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JarbasAl @pep8speaks @forslund @penrods