This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Workaround issue with get_wch on older ncurses #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
get_wch can at times throw errors, this creates a function wait_for_any_key() handling the error and retrying.
forslund
force-pushed
the
bugfix/mint-skill-listing
branch
from
8efcfe2
to
a783da2
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
|
Any chance of getting this reviewed @krisgesling? |
|
Thanks for the nudge - looks good, working great. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_wch()can at times throw errors as reported in #2523, this creates a function wait_for_any_key() handling the error and retrying.How to test
Make sure the :skills command still works in the CLI.
Contributor license agreement signed?
CLA [ Yes ]