This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Disable wake word upload for v20.2 #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Tested and working as described. I assume the code is just commented out to be easy to reuse when it's reactivated for the new endpoint. Good catch on the duplicate method, probably an artifact from the earlier refactoring here. |
|
Voight Kampff Integration Test Failed (Results) |
chrisveilleux
approved these changes
Aug 14, 2020
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API endpoint used to upload wake words will be deprecated in the near future and instead shifted to Selene. To ensure older devices are not making unnecessary post requests to a dead endpoint, this disables that request.
In looking at this, there also seems to be a duplicate and unused method that doesn't use threading, so this has been removed entirely.
How to test
Ensure you are opted in and wake word upload is not disabled in your config. Set log level to debug and trigger the wake word.
Contributor license agreement signed?