Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete coverage for CheckLuhnSuffixReturnString #22

Closed
MylesFTOP opened this issue Jul 23, 2020 · 1 comment
Closed

Complete coverage for CheckLuhnSuffixReturnString #22

MylesFTOP opened this issue Jul 23, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MylesFTOP
Copy link
Owner

Per issue #20, current coverage for LuhnLibrary is 88.9%, with only one method uncovered - CheckLuhnSuffixReturnString, which is essentially a wrapper for CheckLuhnSuffixReturnBool to return strings of "valid" or "not valid" instead of a boolean.

While the function is relatively trivial (I'm hesitant to compare literals if it doesn't affect the internal logic of the program - this is just standardising the output for re-use, so it's bordering on UI logic), it may be worth making sure that the function is returning a string to catch any regressions (even though the return type is right there in the method name).

Originally posted by @MylesFTOP in #20 (comment)

@MylesFTOP MylesFTOP changed the title Complete coverage for CheckLuhnSuffixReturnString Complete coverage for CheckLuhnSuffixReturnString Jul 23, 2020
@MylesFTOP MylesFTOP self-assigned this Jul 23, 2020
@MylesFTOP MylesFTOP added the enhancement New feature or request label Jul 23, 2020
MylesFTOP added a commit that referenced this issue Jul 24, 2020
@MylesFTOP
Copy link
Owner Author

Now showing as 100% coverage with commit 083faf8. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant