Gymnasium Upgrade #142
Merged
Gymnasium Upgrade #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Pinning back the gym version.
Merge pull request #129 from MyoHub/add_gymz_vk - Gym/Gymnasium import. - Examine_sim upgraded to mujoco bindings - Hardcoded enums removed from the robot. - Model as a string accepted to create a scene. - All tests passed on the different gym versions. - All tests passing on all tutorials
Adding Gymnasium Compatibility
- env_base reset passed seed properly - env_base respects horizon computtation based on gym/gynmansium - myodm reset passes kwargs properly - examine_reference, test_envs, examine_env uses env.unwrapped - renderer handles ARB_clip_control warning - robot class closes properly and provides warning when user leaves connection open before exit - prompt_utils options upgraded for better clarity
|
@vikashplus can you please check if the changelog is correct? |
Vittorio-Caggiano
requested changes
Feb 4, 2024
| @@ -77,6 +81,59 @@ def vc_isavailable(): | |||
| if importlib.util.find_spec("vc_models") is None: | |||
| raise ModuleNotFoundError(help) | |||
|
|
|||
| def simhive_isavailable(robohive_version): | |||
There was a problem hiding this comment.
this doesn't seem to belong here, yet
| import os | ||
| from os.path import expanduser | ||
| import git | ||
|
|
||
|
|
||
| def mujoco_py_isavailable(): |
There was a problem hiding this comment.
we no longer support mujoco_py ... should we remove this?
| @@ -13,7 +13,8 @@ pip3 install scikit-learn | |||
| # Install potential missing packages needed for the tutorials | |||
| pip3 install jupyter ipykernel tabulate matplotlib torch h5py | |||
| pip3 install git+https://github.com/aravindr93/mjrl.git@pvr_beta_1vk # install from branch `pvr_beta_1vk` compatible with `mujoco` native binding | |||
There was a problem hiding this comment.
can we have this fix from Arvind in mjrl main? this here forces to pull from the branch but users installing from main might not find easily this fix
| @@ -12,7 +12,7 @@ def __init__(self, name, **kwargs): | |||
| # parse path from robohive format into robopen dataset format | |||
| def path2dataset(self, path:dict, config_path=None)->dict: | |||
| """ | |||
| Convert Robohive format into roboset format | |||
| Convert RoboHive format into roboset format | |||
There was a problem hiding this comment.
do we have a link to documentation for the 'Robohive format'
… By default path_utils uses unwrapped envs now
Naming consistency for myohand_object and myohand_tabletop
…cameras - default was point to the free camera, this is not desirable and can lead to silent bugs - offscreen rendering images were flipped. Adjusted to be compatible with latest version of MuJoCo
| @@ -9,3 +9,5 @@ mujoco==2.3.7 | |||
| dm-control==1.0.14 | |||
| Pillow | |||
| pink-noise-rl | |||
| packaging | |||
| gitpython | |||
There was a problem hiding this comment.
this should not be needed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.