Clean up trait bounds + safer group checks #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-lj
changed the title
jonas-lj
changed the title
kchalkias
approved these changes
May 14, 2024
| let x = | ||
| QuadraticForm::hash_to_group_with_default_parameters(&[0, 1, 2], &discriminant).unwrap(); | ||
| let y = | ||
| QuadraticForm::hash_to_group_with_default_parameters(&[3, 4, 5], &discriminant).unwrap(); |
There was a problem hiding this comment.
ah previously it was just a product of generator and now they are random? Nice, that's better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Multrait is not needed for ParameterizedGroupElement's nor for the windowed multiplier.This PR also changes the
discriminantmethod for class group elements to return a BigInt instead of a wrappedDiscriminant. This is to give a stronger guarantee thatDiscriminantobjects have been validated at some point.