Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in text and code examples #80

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Fix minor typos in text and code examples #80

merged 9 commits into from
Jun 24, 2024

Conversation

yjshi2015
Copy link
Contributor

  • An example of a little-endian sequence is 0x2a00000000000000, not 0x000000000000002a
  • Fix typos
  • Improve code and description

@damirka
Copy link
Collaborator

damirka commented Jun 20, 2024

Hey @yjshi2015! Thank you for the PR. Suggestions look good with a few notes.

Could you please revert the changes to the sample code and update the PR to fix the merge conflict? Samples are intentionally not padded, and the test function should also not be included in the final output (marked by ANCHOR -> ANCHOR_END pair)

@yjshi2015
Copy link
Contributor Author

Hey @yjshi2015! Thank you for the PR. Suggestions look good with a few notes.

Could you please revert the changes to the sample code and update the PR to fix the merge conflict? Samples are intentionally not padded, and the test function should also not be included in the final output (marked by ANCHOR -> ANCHOR_END pair)

ok, I had done, plz check, Thx~

Copy link
Collaborator

@damirka damirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you a lot!

@damirka damirka merged commit 84b29e1 into MystenLabs:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants