Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc & indexer: get latest owned objects #10275

Merged
merged 1 commit into from
Apr 3, 2023
Merged

rpc & indexer: get latest owned objects #10275

merged 1 commit into from
Apr 3, 2023

Conversation

gegaowp
Copy link
Contributor

@gegaowp gegaowp commented Apr 1, 2023 •
edited
Loading

Description

getOwnedObjects should always return latest objects, if pagination happens, it is expected to have some accuracy problems; If ppl care, they should use queryObjects and specify checkpoint instead.

Test

CI

@vercel
Copy link

vercel bot commented Apr 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:41am
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:41am
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:41am
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:41am

@gegaowp gegaowp marked this pull request as ready for review April 1, 2023 21:14
@gegaowp gegaowp force-pushed the obj-read branch 4 times, most recently from 52715f4 to cfa241e Compare April 2, 2023 05:26
@gegaowp
Copy link
Contributor Author

gegaowp commented Apr 2, 2023 •
edited
Loading

@patrickkuo I already moved the api endpoint to read & read_api but realized a couple of things so I reverted it:

  • in the Rust SDK, other than address, it also uses object_type filter, so compared with adding a StructTag there, I just kept the query;
  • regarding read.rs <> indexer.rs, b/c of the object type query & also the fact that owner_index is in indexerStore, so I decided to keep it in indexer.rs.

Hope that makes sense and happy to huddle!

@gegaowp gegaowp force-pushed the obj-read branch 5 times, most recently from 52794ac to 9f885cc Compare April 2, 2023 20:09
@gegaowp gegaowp force-pushed the obj-read branch 2 times, most recently from a9f3679 to 483a662 Compare April 3, 2023 00:27
@gegaowp gegaowp enabled auto-merge (squash) April 3, 2023 02:58
@gegaowp gegaowp merged commit 5a4e3e4 into MystenLabs:main Apr 3, 2023
@gegaowp gegaowp deleted the obj-read branch April 3, 2023 03:19
@gegaowp gegaowp mentioned this pull request Apr 3, 2023
Merged
gegaowp added a commit that referenced this pull request Apr 3, 2023
@gegaowp
ts sdk: backward compatible getOwnedObject (#10333)
27dec39 
related PR is #10275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@666lcz 666lcz 666lcz approved these changes

@patrickkuo patrickkuo Awaiting requested review from patrickkuo

@healthydeve healthydeve Awaiting requested review from healthydeve

@wlmyng wlmyng Awaiting requested review from wlmyng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gegaowp @666lcz