Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to publish/upgrade methods in (Programmable)TransactionBuilder #14793

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Nov 12, 2023

Description

As a downstream consumer of sui-sdk, I found it a little difficult to understand how to use TransactionBuilder::{publish, upgrade} without jumping some IDE hoops.
Hopefully, the documentation added in this PR will help others who are also unfamiliar with the codebase.

Test Plan

No tests required.

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 1:38am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 1:38am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 1:38am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 1:38am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 1:38am

@oxade
Copy link
Contributor

oxade commented Nov 12, 2023

Thanks for bringing this to our attention and for putting up this PR! Please let us know if anything else could use better documentation.
I'll approve & merge this PR once the doc tests are fixed. Try adding "```rust,ignore" to the comments or using the proper type path

@rockbmb
Copy link
Contributor Author

rockbmb commented Nov 13, 2023

@oxade quick question: when you say

using the proper type path

do you mean for this PR to use relative paths?

I've taken a look at

and it would seem this is the only way to have links in documentation that does not require introducing dependencies.

@oxade
Copy link
Contributor

oxade commented Nov 13, 2023

@oxade quick question: when you say

using the proper type path

do you mean for this PR to use relative paths?

I've taken a look at

and it would seem this is the only way to have links in documentation that does not require introducing dependencies.

For simplicity, you could just use rust,ignore in the comments.

Copy link

@OPTIMUS-PX OPTIMUS-PX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish upgrade

Copy link

vercel bot commented Nov 13, 2023

@rockbmb is attempting to deploy a commit to the Sui Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@rockbmb
Copy link
Contributor Author

rockbmb commented Nov 14, 2023

@oxade should be fixed, now.

By the way:

Please let us know if anything else could use better documentation.

I will - as I continue to use the SDK, I'll be submitting more PRs if I find anything I can help clarify for other users.

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants