-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to publish/upgrade
methods in (Programmable)TransactionBuilder
#14793
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Thanks for bringing this to our attention and for putting up this PR! Please let us know if anything else could use better documentation. |
@oxade quick question: when you say
do you mean for this PR to use relative paths? I've taken a look at
and it would seem this is the only way to have links in documentation that does not require introducing dependencies. |
For simplicity, you could just use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publish upgrade
@rockbmb is attempting to deploy a commit to the Sui Foundation Team on Vercel. A member of the Team first needs to authorize it. |
@oxade should be fixed, now. By the way:
I will - as I continue to use the SDK, I'll be submitting more PRs if I find anything I can help clarify for other users. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
As a downstream consumer of
sui-sdk
, I found it a little difficult to understand how to useTransactionBuilder::{publish, upgrade}
without jumping some IDE hoops.Hopefully, the documentation added in this PR will help others who are also unfamiliar with the codebase.
Test Plan
No tests required.