Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Fix and add interactive disassembler #17986

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented May 30, 2024

Description

Fixes the interactive disassembler, and adds the flag for it to sui move disassemble (with the -i flag). See screencast for what this looks like.

disassembler_interactive.mov

Test plan

👀


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: Adds new -i flag to sui move disassemble that creates an interactive disassembled bytecode-to-source explorer.
  • Rust SDK:

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) May 30, 2024 1:20am
sui-kiosk ⬜️ Ignored (Inspect) May 30, 2024 1:20am
sui-typescript-docs ⬜️ Ignored (Inspect) May 30, 2024 1:20am

@tzakian tzakian requested review from a team and dariorussi May 30, 2024 01:20
Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 I will close my eyes to that cool regex!

@tzakian tzakian merged commit d44f1c0 into main May 30, 2024
50 checks passed
@tzakian tzakian deleted the tzakian/interactive-diss branch May 30, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants