-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] fix sui keytool zk-login-sign-and-execute-tx
command bug
#17989
Conversation
Co-authored-by: stefan-mysten <135084671+stefan-mysten@users.noreply.github.com>
…her values after burning if the supply is maxed out
…n inputting mnemonic phrase
…n inputting mnemonic phrase
@bityoume is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
curious why do you need this cli ? while im ok with this change to make it more resilient, this is for our testing scaffolding to work, but it only works for devnet or localnet. |
@joyqvq Because I am writing an introductory article about the SUI CLI, so I am trying out each command :) |
@stefan-mysten I have already added a descriptive message for the release notes section, is that ok? |
Looks good, thanks @bityoume! |
…tenLabs#17989) ## Description [CLI] fix `sui keytool zk-login-sign-and-execute-tx` command bug ![image](https://github.com/MystenLabs/sui/assets/123343203/559180fc-e01e-43ff-99d6-e57fe14253aa) ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the code to ensure it has a `gas coin` for the `sui keytool zk-login-sign-and-execute-tx` command. - [ ] Rust SDK: --------- Co-authored-by: stefan-mysten <135084671+stefan-mysten@users.noreply.github.com> Co-authored-by: howtosui <jasonrzx@gmail.com>
Description
[CLI] fix
sui keytool zk-login-sign-and-execute-tx
command bugTest plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
gas coin
for thesui keytool zk-login-sign-and-execute-tx
command.