Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Make prerender clever errors to use context instead of client #19506

Merged

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Sep 23, 2024

Description

Fixes the issue that if the active env cannot be connected to, active-env and envs do not display the output but instead a low level network error appears.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: Fixes an issue with active-env and envs commands that were not showing an output if the active RPC URL was not correct.
  • Rust SDK:
  • REST API:

@stefan-mysten stefan-mysten requested review from tzakian, damirka and a team September 23, 2024 20:05
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 8:05pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 8:05pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 8:05pm

Copy link
Contributor

@damirka damirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me. But I'm not the most knowledgeable person when it comes to CLI types.

@stefan-mysten stefan-mysten merged commit d2a5f44 into MystenLabs:main Sep 23, 2024
43 checks passed
@stefan-mysten stefan-mysten deleted the cli_fix_error_message_active_env branch September 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants