indexer: add indices to aid pruning #19543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description All the transaction and events lookup tables are missing indices that allow the pruner to efficiently pick out the ranges of rows to remove. Note that because these indices are being added to existing tables, they are being added using `CONCURRENTLY IF NOT EXISTS`, and because of that, they need to each be in their own migration file (concurrent index creation cannot go in a DB transaction). ## Test plan ``` sui$ ./scripts/generate_indexer_schema.sh ```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gegaowp
approved these changes
Sep 25, 2024
crates/sui-indexer/migrations/pg/2024-09-25-135801_event_emit_module_pruning_index/down.sql
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the transaction and events lookup tables are missing indices that allow the pruner to efficiently pick out the ranges of rows to remove.
Note that because these indices are being added to existing tables, they are being added using
CONCURRENTLY IF NOT EXISTS, and because of that, they need to each be in their own migration file (concurrent index creation cannot go in a DB transaction).Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.