[core] Fix input object generation #7940
Conversation
tnowacki
commented
Jan 31, 2023
tnowacki
commented
- packages used in type arguments were not included in input objects
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
There was a problem hiding this comment.
Note that there was another issue that came up during the incident where if the package for a type argument does not exist, a validator could end up waiting forever for it, so holding off on the accept until we know what the implications of that are, but the change does look good, cc @bmwill who was dealing with that.
crates/sui-types/src/messages.rs
Outdated
| .collect() | ||
| } | ||
|
|
||
| fn type_argument_packages(packages: &mut BTreeSet<ObjectID>, type_argument: &TypeTag) { |
There was a problem hiding this comment.
nit: This could be a top-level function, and probably the name should hint that it's accumulating the package names into packages, how about add_type_argument_packages?
That should be covered? though I'm not sure exactly how that bug came about. |
Yes this will be covered by this PR. |
|
Does this mean we could get rid of this error type since these should be impossible now? https://github.com/MystenLabs/sui/blob/main/crates/sui-types/src/messages.rs#L1550 |
Ya know... this should have been a big hint to us in retrospect |
- packages used in type arguments were not included in input objects
- packages used in type arguments were not included in input objects
