Skip to content

Commit 0ac73fb

Browse files
author
Robert McNamara
committed
Firewire: Add a new DCX-3200 model and split out generic changers.
Add a DCX-3200 model reported on the list. While I was looking at it, I noticed that the fallback changer (DEFAULT) only follows the Scientific Atlanta/Cisco STB code path. So, I split the GENERIC STB into two different boxes. A quick analysis of the code of some of the other firewire changers out there suggests that nearly every single Motorola box will behave with the code we use to change "known" motorola STBs. So, now there's a Generic SA device and a Generic Motorola selection. If the motorola STB isn't already in the code, the Motorola Generic should work pretty reliably without new code.
1 parent c50a072 commit 0ac73fb

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

mythtv/libs/libmythtv/firewiredevice.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ bool FirewireDevice::SetChannel(const QString &panel_model,
180180
vector<uint8_t> cmd;
181181
vector<uint8_t> ret;
182182

183-
if ((panel_model.toUpper() == "GENERIC") ||
183+
if ((panel_model.toUpper() == "SA GENERIC") ||
184184
(panel_model.toUpper() == "SA4200HD") ||
185185
(panel_model.toUpper() == "SA4250HDC"))
186186
{
@@ -230,6 +230,7 @@ bool FirewireDevice::SetChannel(const QString &panel_model,
230230
(panel_model.toUpper().left(4) == "DCH-") ||
231231
(panel_model.toUpper().left(4) == "DCX-") ||
232232
(panel_model.toUpper().left(4) == "QIP-") ||
233+
(panel_model.toUpper().left(4) == "MOTO") ||
233234
(panel_model.toUpper().left(5) == "PACE-"));
234235

235236
if (is_mot && !alt_method)
@@ -359,7 +360,7 @@ QString FirewireDevice::GetModelName(uint vendor_id, uint model_id)
359360
QString ret = s_id_to_model[(((uint64_t) vendor_id) << 32) | model_id];
360361

361362
if (ret.isEmpty())
362-
return "GENERIC";
363+
return "MOTO GENERIC";
363364

364365
ret.detach();
365366
return ret;
@@ -424,7 +425,7 @@ static void fw_init(QMap<uint64_t,QString> &id_to_model)
424425
{
425426
/* DCH-3200, DCX-3200 */
426427
0x1c11, 0x1cfb, 0x1fc4, 0x23a3, 0x23ee, 0x25f1,
427-
0xfa01, 0x25f2,
428+
0xfa01, 0x25f1, 0x25f2,
428429
/* DCX-3432 */
429430
0x24a0,
430431
/* DCH-3416 */
@@ -458,6 +459,7 @@ static void fw_init(QMap<uint64_t,QString> &id_to_model)
458459
for (uint i = 0; i < motorola_vendor_id_cnt; i++)
459460
{
460461
id_to_model[motorola_vendor_ids[i] << 32 | 0xf740] = "DCX-3200";
462+
id_to_model[motorola_vendor_ids[i] << 32 | 0xf804] = "DCX-3200";
461463
id_to_model[motorola_vendor_ids[i] << 32 | 0xfa03] = "DCX-3200";
462464
id_to_model[motorola_vendor_ids[i] << 32 | 0xfa07] = "DCX-3200";
463465
id_to_model[motorola_vendor_ids[i] << 32 | 0x24a1] = "DCX-3200";
@@ -511,6 +513,7 @@ bool FirewireDevice::IsSTBSupported(const QString &panel_model)
511513
(model == "PACE-779") ||
512514
(model == "QIP-6200") ||
513515
(model == "QIP-7100") ||
514-
(model == "GENERIC"));
516+
(model == "SA GENERIC") ||
517+
(model == "MOTO GENERIC"));
515518
}
516519

mythtv/libs/libmythtv/videosource.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1176,7 +1176,8 @@ FirewireModel::FirewireModel(const CaptureCard &parent,
11761176
guid(_guid)
11771177
{
11781178
setLabel(QObject::tr("Cable box model"));
1179-
addSelection(QObject::tr("Generic"), "GENERIC");
1179+
addSelection(QObject::tr("Motorola Generic"), "MOTO GENERIC");
1180+
addSelection(QObject::tr("SA/Cisco Generic"), "SA GENERIC");
11801181
addSelection("DCH-3200");
11811182
addSelection("DCX-3200");
11821183
addSelection("DCT-3412");

0 commit comments

Comments
 (0)