Initialize the MythUIImage filename correctly

Beirdo · Beirdo · commit c321ee6a821f · 2011-05-27T19:39:21.000-07:00
Fixes #9634. Fixes #9708. Refs #9547. If the filename does not start with "/", "http://", "https://" or "ftp://", then the actual filename loaded is uninitialized. It can be any random crap on the stack. I'm honestly surprised this worked at all :) This may fix things for #9547 as well, and should be tested with that scenario too. (cherry picked from commit 2c7735e)
diff --git a/mythtv/libs/libmythui/mythuiimage.cpp b/mythtv/libs/libmythui/mythuiimage.cpp
@@ -84,7 +84,7 @@ class ImageLoadThread : public QRunnable
 
     void run()
     {
-        QString tmpFilename;
+        QString tmpFilename = m_filename;
         if ((m_filename.startsWith("/")) ||
             (m_filename.startsWith("http://")) ||
             (m_filename.startsWith("https://")) ||

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ class ImageLoadThread : public QRunnable`
`84`	`84`
`85`	`85`	`void run()`
`86`	`86`	`{`
`87`		`- QString tmpFilename;`
	`87`	`+ QString tmpFilename = m_filename;`
`88`	`88`	`if ((m_filename.startsWith("/")) \|\|`
`89`	`89`	`(m_filename.startsWith("http://")) \|\|`
`90`	`90`	`(m_filename.startsWith("https://")) \|\|`