Skip to content
Browse files

Initialize the MythUIImage filename correctly

Fixes #9634.  Fixes #9708.  Refs #9547.

If the filename does not start with "/", "http://", "https://" or "ftp://", then
the actual filename loaded is uninitialized.  It can be any random crap on the
stack.  I'm honestly surprised this worked at all :)

This may fix things for #9547 as well, and should be tested with that
scenario too.
(cherry picked from commit 2c7735e)
  • Loading branch information...
1 parent 9375ffb commit c321ee6a821f2a773f0d8d158d27d83b70c9332d @Beirdo Beirdo committed
Showing with 1 addition and 1 deletion.
  1. +1 −1 mythtv/libs/libmythui/mythuiimage.cpp
2 mythtv/libs/libmythui/mythuiimage.cpp
@@ -84,7 +84,7 @@ class ImageLoadThread : public QRunnable
void run()
- QString tmpFilename;
+ QString tmpFilename = m_filename;
if ((m_filename.startsWith("/")) ||
(m_filename.startsWith("http://")) ||
(m_filename.startsWith("https://")) ||

0 comments on commit c321ee6

Please sign in to comment.
Something went wrong with that request. Please try again.