Add annotations to three flags to eliminate if possible.

MythTV · Jun 2, 2013 · c84137d · c84137d
1 parent 0585a99
commit c84137d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/mythtv/libs/libmythbase/mythsystem.h b/mythtv/libs/libmythbase/mythsystem.h
@@ -39,15 +39,19 @@ typedef enum MythSystemMask {
     kMSRunBackground      = 0x00000004, ///< run child in the background
     kMSProcessEvents      = 0x00000008, ///< process events while waiting
     kMSInUi               = 0x00000010, ///< the parent is in the UI
+    // ^ FIXME Eliminate? appears entirely unused.
     kMSStdIn              = 0x00000020, ///< allow access to stdin
     kMSStdOut             = 0x00000040, ///< allow access to stdout
     kMSStdErr             = 0x00000080, ///< allow access to stderr
     kMSRunShell           = 0x00000200, ///< run process through shell
     kMSAnonLog            = 0x00000800, ///< anonymize the logs
     kMSSetPGID            = 0x00002000, ///< set the process group id
+    // ^ FIXME Eliminate? appears to not be used + not available on windows
     kMSAutoCleanup        = 0x00004000, ///< automatically delete if
                                         ///  backgrounded
     kMSLowExitVal         = 0x00008000, ///< allow exit values 0-127 only
+    // ^ FIXME Eliminate? appears to be a hack for some "ubuntu", but
+    //                    doesn't appear to be needed with ubuntu 12.04
     kMSDisableUDPListener = 0x00010000, ///< disable MythMessage UDP listener
                                         ///  for the duration of application.
     kMSPropagateLogs      = 0x00020000, ///< add arguments for MythTV log

diff --git a/mythtv/libs/libmythbase/test/test_mythsystem/test_mythsystem.h b/mythtv/libs/libmythbase/test/test_mythsystem/test_mythsystem.h
@@ -108,7 +108,6 @@ class TestMythSystem: public QObject
     }
 
     // TODO kMSProcessEvents      -- process events while waiting
-    // TODO kMSInUi               -- the parent is in the UI
 
     // kMSStdIn              -- allow access to stdin
     void stdin_works(void)
@@ -194,9 +193,6 @@ class TestMythSystem: public QObject
 #endif
     }
 
-    // TODO flags to test
-    // TODO kMSSetPGID            -- set the process group id
-
     // kMSAutoCleanup        -- automatically delete if backgrounded
     void auto_cleanup_return_null(void)
     {
@@ -205,7 +201,6 @@ class TestMythSystem: public QObject
         QVERIFY(!ptr);
     }
 
-    // TODO kMSLowExitVal         -- allow exit values 0-127 only
     // TODO kMSDisableUDPListener -- disable MythMessage UDP listener
     //                               for the duration of application.
     // TODO kMSPropagateLogs      -- add arguments for MythTV log propagation

diff --git a/mythtv/libs/libmythbase/test/test_mythsystemlegacy/test_mythsystemlegacy.h b/mythtv/libs/libmythbase/test/test_mythsystemlegacy/test_mythsystemlegacy.h
@@ -125,7 +125,6 @@ class TestMythSystemLegacy: public QObject
     }
 
     // TODO kMSProcessEvents      -- process events while waiting
-    // TODO kMSInUi               -- the parent is in the UI
 
     // kMSStdIn              -- allow access to stdin
     void stdin_works(void)
@@ -195,9 +194,7 @@ class TestMythSystemLegacy: public QObject
     }
 
     // TODO flags to test
-    // TODO kMSSetPGID            -- set the process group id
     // TODO kMSAutoCleanup        -- automatically delete if backgrounded
-    // TODO kMSLowExitVal         -- allow exit values 0-127 only
     // TODO kMSDisableUDPListener -- disable MythMessage UDP listener
     //                               for the duration of application.
     // TODO kMSPropagateLogs      -- add arguments for MythTV log propagation