Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some WARCs lack bookmarks according to Webrecorder player #25

Closed
peterk opened this issue Dec 11, 2018 · 2 comments · Fixed by #26
Closed

Some WARCs lack bookmarks according to Webrecorder player #25

peterk opened this issue Dec 11, 2018 · 2 comments · Fixed by #26

Comments

@peterk
Copy link

peterk commented Dec 11, 2018

Archived the following URL: https://www.facebook.com/socialdemokraternailjusdal/photos/a.1409766429240263/2084031858480380/?type=3&__xts__%5B0%5D=68.ARA3blS6QVatnljfKg2ED3yFCSVs2fEjWVC085o9H1oNPpiSDeld4Iu5HfWS59RvuteqLBXXBZZj0oN9I8r0S7RxjC_W77aYdiOtyPeaVCRfYm0O1rgzzqnYDIZTXDJEYPG-XJ0dpOoaGR8JI0JbP6NPCTYXaKKEPUUUKg1XihsVouag0W91ra3-Rqr-TpDrPm96rVOvgjIy8oe5Kse0ZV50kJ65pwWhKvBxm7bMoyTo1fsXAkK6sYdaM_iQhbT7PO25qk6VUbbrTlHSu5i7a3idF2huVM4KM7s-LaOZMPztninlNYMFjCjbJpOeK8wgNUrcXdzwPLsS3iYZ4-D4RcYwPSsU&__tn__=-R

Opening the resulting WARC in Webrecorder Player shows "No bookmarks available in the table":
image

Maybe the URL is too long or not escaped properly? Other (shorter) URLs seem to work fine.

Example zipped WARC file below.

fbtest.warc.zip
@peterk peterk mentioned this issue Dec 12, 2018
Open
@peterk
Copy link
Author

peterk commented Dec 12, 2018

I am thinking this is a bug in Webrecorder player as it opens fine in openwayback.

@N0taN3rd
Copy link
Owner

This is definitively more of an issue with page detection rather than can play back.
Blind page discovery is hard... But we are looking into how to solve this issue.
Ref comment by @ikreymer in webrecorder/webrecorder-player#77

N0taN3rd added a commit that referenced this issue Dec 28, 2018
@N0taN3rd
Added to all writers the ability to write a Webrecorder Player compat…
cbc591d 
…ible bookmark list (as WARC info record) via

WARCWriterBase.writeWebrecorderBookmarksInfoRecord and the pages property of the genOpts object supplied
to generateWARC fixes #25
N0taN3rd added a commit that referenced this issue Dec 28, 2018
@N0taN3rd
Allow full control over the contents of the WARC info record fixes #22
48cd9aa 
longer require including the extension in the name for the WARC file to be created, it will be added if it is omitted
allow the default WARC file option can now be supplied as the only argument to the constructor of all writers or set via

treat the post data retrieved via `Network.getRequestPostData` as utf-8 strings rather than base64 encoded strings

Added to all writers the ability to write a Webrecorder Player compatible bookmark list (as WARC info record) via
WARCWriterBase.writeWebrecorderBookmarksInfoRecord and the pages property of the genOpts object supplied
to generateWARC fixes #25

update index.d.ts with 3.2.0 changes
@N0taN3rd N0taN3rd mentioned this issue Dec 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow full control over the contents of the WARC info record fixes #22 N0taN3rd/node-warc
2 participants
@peterk @N0taN3rd