Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests filestation api issue 159 #164

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

fabtesta
Copy link

Hi @N4S4,

to cover the login issues related to #159, I wrote a test class with a config file that could help to cover also the OTP use-case.

config-tests.json examples

## no otp
{
  "synology_ip": "192.168.1.xyz",
  "synology_port": "5001",
  "synology_user": "user_without_otp",
  "synology_password": "password",
  "synology_secure": true,
  "dsm_version": 7,
  "otp_code": null
}

## otp
{
  "synology_ip": "192.168.1.xyz",
  "synology_port": "5001",
  "synology_user": "user_with_otp",
  "synology_password": "password",
  "synology_secure": true,
  "dsm_version": 7,
  "otp_code": "123456"
}

from tests folder

python -m unittest test_syno_api.py

Fabio Testa added 3 commits March 14, 2024 11:06
add test class to implement test cases
add test case to cover filestation login
add test case to cover surveillance station login
add main to run test suite from commandline
@N4S4
Copy link
Owner

N4S4 commented Mar 14, 2024

cool! thank you!

@N4S4 N4S4 merged commit d6ee5c1 into N4S4:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants