Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/search): filtered search via post #29

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat(data/search): filtered search via post #29

merged 2 commits into from
Jul 8, 2024

Conversation

basarbyz
Copy link
Collaborator

This commit creates the
get_datapoints_by_filters function to get
filtered data and handle cases where
nonexistent filters are provided. Instead
of throwing an internal server error, the
function returns an empty list.
Additionally, unit tests have been added to
ensure the function behaves as expected
under various conditions.

@basarbyz
feat(data/search): filtered search via post
cc92500 
This commit creates the
get_datapoints_by_filters function to get
filtered data and handle cases where
nonexistent filters are provided. Instead
of throwing an internal server error, the
function returns an empty list.
Additionally, unit tests have been added to
ensure the function behaves as expected
under various conditions.
@basarbyz basarbyz linked an issue Jun 28, 2024 that may be closed by this pull request
Implement filter function for GET /data endpoint #12
Closed
@basarbyz basarbyz requested a review from djs0109 June 28, 2024 08:14
@basarbyz
Copy link
Collaborator Author

Closes #12

@djs0109
Copy link
Contributor

djs0109 commented Jun 28, 2024

Please implement with query parameters under the endpoint GET /data
Here is a reference https://fastapi.tiangolo.com/tutorial/query-params/
Here is an example Get List Entities /v2/entities

@basarbyz
feat(data): filtered query search via get
292a84a 
Changed the filtered query via post to get
@basarbyz
Copy link
Collaborator Author

basarbyz commented Jul 2, 2024

@djs0109 ive implemented query parameters under the endpoint GET /data

@djs0109 djs0109 merged commit f54d6c1 into main Jul 8, 2024
@basarbyz basarbyz deleted the 12-implement-filter-function-for-get-data-endpoint branch July 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djs0109 djs0109 djs0109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement filter function for GET /data endpoint
2 participants
@basarbyz @djs0109