Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending vehicle_types.json #370

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Extending vehicle_types.json #370

merged 4 commits into from
Dec 15, 2021

Conversation

josee-sabourin
Copy link
Contributor

@josee-sabourin josee-sabourin commented Sep 8, 2021

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

This proposal is in response to the discussion in #319 to extend vehicle_types.json. After an in-depth needs assessment and community consultation, these fields are what appear to be the priority for the GBFS community when it comes to vehicle descriptions. The proposal document can be found here.

What is the proposal?

The proposal adds enums to the form_factor field:

  • cargo_bicycle
  • scooter_seated
  • scooter becomes scooter_standing

The proposal also adds 3 fields to the specification:

  • wheel_count: to inform the user of the number of wheels on the vehicle
  • max_permitted_speed: to inform the user of the maximum speed allowed as well as to better inform trip planners for route planning
  • rated_power: the motor wattage of the vehicle to better inform trip planners.

Is this a breaking change?

  • Yes - however, the proposal can be rewritten to not include the breaking change by specifying that form_factor.scooter implies a standing scooter.
  • No
  • Unsure

Which files are affected by this change?

  • vehicle_types.json

@josee-sabourin josee-sabourin mentioned this pull request Sep 8, 2021
3 tasks
@heidiguenin heidiguenin mentioned this pull request Sep 8, 2021
@bartwr
Copy link

bartwr commented Sep 9, 2021

Looking good! We definitely can use this in The Netherlands, i.e. for listing cargo bikes and 'snorfietsen' (mopeds <= 25 km/h) following this updated standard.

@schnuerle
Copy link
Contributor

Per issue openmobilityfoundation/mobility-data-specification#692 opened by @sven4all, for MDS 1.2.0 we may be able to add cargo_bicycle as a vehicle type, but would not be able to remove scooter as this would be a breaking change. So we would have to revisit later to align these changes to MDS in the next major release 2.0.0, which will start work in the next few weeks.

@sven4all
Copy link
Contributor

Maybe it's a good idea for both MDS and GBFS to introduce scooter_seated and scooter_standing in the next minor release, but still allow scooter (with a will be deprecated in the next major release annotation).

@josee-sabourin
Copy link
Contributor Author

I hereby call a vote on this proposal.

Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@kanagy
Copy link

kanagy commented Nov 29, 2021

Hi, could there be a bit more clarification on the difference between seated_scooter and moped? I read that in the motorcycle world, a scooter is more powerful than moped (e.g. need a motorcycle license in Australia for scooter, but not for moped). However, I thought in the bikeshare world (and in this spec) it was the other way round.

@josee-sabourin
Copy link
Contributor Author

Hi @kanagy
A seated scooter would look like this:
image

Whereas a moped would be this:
image

We can update the documentation to be more clear if this passes.

@sven4all
Copy link
Contributor

+1 from CROW

@cmonagle
Copy link
Contributor

+1 from Transit

@kanagy
Copy link

kanagy commented Nov 30, 2021

+1 From Google Maps. Yes, please clarify the documentation, particularly since this spec will be shared with car sharing (and so potentially motorbike sharing).

@testower
Copy link
Contributor

testower commented Dec 6, 2021

Entur supports this proposal, but I agree with @sven4all that this could easily be introduced as a non-breaking change, with aiming to remove "scooter" in v3.

@nbdh
Copy link
Contributor

nbdh commented Dec 6, 2021

+1 from nextbike

@heidiguenin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@ncancelliere
Copy link

+1 from Spin

@heidiguenin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
CROW (producer)
Transit (consumer)
Google Maps (consumer)
Entur (consumer)
nextbike (producer)
Spin (producer)

There were no votes against.
Thank you to everyone who took the time to review and to vote on this!

We'll update the documentation as discussed, and then we will tag and merge this into v2.3-RC2 (with the non-breaking approach discussed in the proposal) and v3.0-RC2 (with the longer-term breaking approach) in the coming weeks.

Mitch Vars added 3 commits December 15, 2021 10:12
Replaces scooter and adds notes about, corrects reference to home_station_id f
@mplsmitch mplsmitch merged commit 09a1a19 into master Dec 15, 2021
isabelle-dr added a commit to MobilityData/gbfs-json-schema that referenced this pull request Mar 10, 2022
@josee-sabourin josee-sabourin deleted the vehicle-types-extension branch March 13, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v2.3-RC2 v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.