Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list supported currencies #3

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

FrontSide
Copy link
Contributor

Add command to list supported currencies

By using "mmc list" the user can now
get a list of all currencies supported
my mmc. This helps in debugging
usage errors and offers the user to get
an overview of available currency IDs
as they might not always be obvious.
It also provides a way to give inside to the
applications ample capabilities.

@FrontSide
Copy link
Contributor Author

I'd be happy enough to write a test case for the new function if desired.
I haven't so far because it's going to be a bit of awkward work since we'd need to parse textual output and I'm not sure if it's a thing worth testing in the first place.

@NARKOZ
Copy link
Owner

NARKOZ commented Oct 10, 2018

@FrontSide
Copy link
Contributor Author

Mhh how did that happen. I rebased onto my previous PR's branch. Will have a look

By using "mmc list" the user can now
get a list of all currencies supported
my mmc. This helps in debugging
usage errors and offers the user to get
an overview of available currency IDs
as they might not always be obvious.
It also provides a way to give inside to the
applications ample capabilities.

Signed-off-by: David <david@isan.engineer>
@FrontSide FrontSide force-pushed the add-list-supported-currencies branch from fea1cb7 to b374b79 Compare October 10, 2018 18:47
@FrontSide
Copy link
Contributor Author

done

@NARKOZ NARKOZ merged commit 65d908d into NARKOZ:master Oct 11, 2018
@NARKOZ
Copy link
Owner

NARKOZ commented Oct 11, 2018

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants