Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CameraTransition: Transitioning with a very far away point causes issues on the globe #619

Closed
gkjohnson opened this issue Jul 15, 2024 · 2 comments · Fixed by #621 or #830
Closed
Milestone

Comments

@gkjohnson
Copy link
Contributor

No description provided.

@gkjohnson gkjohnson added this to the v0.3.36 milestone Jul 15, 2024
gkjohnson added a commit that referenced this issue Jul 16, 2024
gkjohnson added a commit that referenced this issue Jul 16, 2024
* Add a helper

* Update utility

* Related to #619

* fixes

* comments
@gkjohnson gkjohnson reopened this Jul 16, 2024
@gkjohnson
Copy link
Contributor Author

This likely due to the perspective camera being positioned under the terrain after the transition resulting in the camera rotation being angled incorrectly.

@gkjohnson
Copy link
Contributor Author

gkjohnson commented Oct 25, 2024

To handle this the manager should be able to transition between cameras at different positions with different near / far plane. However this makes it difficult to keep a "fixed" point during transitions meaning that the fixed point will "swim" but only in the case that the camera must be shifted after syncing positions.

Update cycle from #821

  • Sync camera positions and views
  • Update camera positions, views, etc from controls
  • Perform transition
    • Recompute "fixedHeight" for every transition step
    • Transition orientation (though ideally it shouldn't be different)
    • Transition the position of each camera, which is ultimately used to model the "ray" that each camera is looking along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant