-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #73 - CFDP send/receive over UDP socket connection #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aywaldron
commented
Aug 23, 2019
•
edited
Loading
edited
- CFDP implementation can now send/receive over UDP ports - a single CFDP entity can send & receive over the same or different ports.
- By default an entity only connects to a receiving port if a sending port is not specified.
- The example scripts now send/receive over different corresponding ports for testing on the same machine (i.e. the sending entity sends over the same port that the receiving entity receives on, and vice versa).
- Option to send/receive over file system can be passed into CFDP initializer as kwarg
- Some formatting and typos fixed.
- Option to send/receive over file system can be passed into CFDP initializer as kwarg - Can send/receive over different or same ports - example scripts send/receive over different corresponding ports for testing on same machine - Fix some formatting and typos
MJJoyce
reviewed
Aug 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Few minor comments
MJJoyce
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.