Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #73 - CFDP send/receive over UDP socket connection #81

Merged
merged 9 commits into from
Sep 9, 2019

Conversation

aywaldron
Copy link
Contributor

@aywaldron aywaldron commented Aug 23, 2019

  • CFDP implementation can now send/receive over UDP ports - a single CFDP entity can send & receive over the same or different ports.
  • By default an entity only connects to a receiving port if a sending port is not specified.
  • The example scripts now send/receive over different corresponding ports for testing on the same machine (i.e. the sending entity sends over the same port that the receiving entity receives on, and vice versa).
  • Option to send/receive over file system can be passed into CFDP initializer as kwarg
  • Some formatting and typos fixed.

- Option to send/receive over file system can be passed into CFDP
initializer as kwarg
- Can send/receive over different or same ports - example scripts
send/receive over different corresponding ports for testing on
same machine
- Fix some formatting and typos
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few minor comments

ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
ait/dsn/cfdp/cfdp.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants