feat: add plan lock/unlock functionality #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camargo
reviewed
Aug 22, 2022
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
feat: add plan lock/unlock functionality (#101) * add ui control for locking/unlocking timeline * add colors for temp unlocked state * disable dragging on activity layer if timeline is in locked state * don't activate temp unlock if focusing input * add tooltip explaining temporary unlock instructions * update stellar to get correct icons
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
feat: add plan lock/unlock functionality (#101) * add ui control for locking/unlocking timeline * add colors for temp unlocked state * disable dragging on activity layer if timeline is in locked state * don't activate temp unlock if focusing input * add tooltip explaining temporary unlock instructions * update stellar to get correct icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent users from accidentally moving activities, timelines are now locked by default. They can be unlocked by clicking the lock icon, or temporarily unlocked by holding Shift. There was some previous discussion about using Control instead of Shift to activate this functionality. But then I remembered that Control + Click by default brings up the context menu in browsers. So I thought it didn't seem wise to overwrite that functionality without a good reason, so we went with Shift for now.
One thing to note is that this lock control will lock/unlock any/all active timelines. i.e. if you are displaying two timelines at once, clicking the lock icon will unlock both. I think ultimately that might be what we want to happen anyway, but not sure if we think we should make each lock icon paired to the specific timeline instance. It would be harder to split the holding shift functionality, so I figured sticking with a global control probably makes sense for now.