New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose model upload errors #1319

Merged

duranb merged 27 commits into develop from feature/model-upload-errors

Jun 13, 2024

Collaborator

duranb commented Jun 4, 2024 •

edited

Loading

Resolves #1248

To test:

Start up local development as usual
Navigate to model upload page
Stop the aerie_merlin container
Proceed with creating a model
Verify that it forwards you to the newly created model
Verify that errors appear on the created model's page
Create a plan using the broken model
Verify that a banner appears at the top stating that model errors are present
Click on the "View Errors in Console" button
Verify that the console opens up and displays the model errors with clickable buttons to view more information about each error

Follow-up ticket: #1326

duranb requested a review from a team as a code owner

June 4, 2024 20:22

duranb requested review from dandelany, AaronPlave and joswig

June 4, 2024 20:22

duranb had a problem deploying to test-workflow

June 4, 2024 20:22

— with

GitHub Actions Failure

duranb added the feature label

duranb temporarily deployed to test-workflow

June 4, 2024 23:56

— with

GitHub Actions Inactive

duranb force-pushed the feature/model-upload-errors branch from e497e49 to b329edc Compare

June 5, 2024 00:04

duranb temporarily deployed to test-workflow

June 5, 2024 00:05

— with

GitHub Actions Inactive

duranb force-pushed the feature/model-upload-errors branch from b329edc to e497e49 Compare

June 5, 2024 22:27

duranb temporarily deployed to test-workflow

June 5, 2024 22:27

— with

GitHub Actions Inactive

duranb force-pushed the feature/model-upload-errors branch from e497e49 to a2c0ecc Compare

June 5, 2024 22:28

duranb temporarily deployed to test-workflow

June 5, 2024 22:28

— with

GitHub Actions Inactive

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Outdated Show resolved Hide resolved

duranb temporarily deployed to test-workflow

June 7, 2024 00:01

— with

GitHub Actions Inactive

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/plan/PlanModelErrorBar.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/plan/PlanModelErrorBar.svelte Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/console/views/ModelErrors.svelte Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Show resolved Hide resolved

duranb temporarily deployed to test-workflow

June 7, 2024 01:42

— with

GitHub Actions Inactive

duranb temporarily deployed to test-workflow

June 7, 2024 08:24

— with

GitHub Actions Inactive

duranb temporarily deployed to test-workflow

June 7, 2024 16:57

— with

GitHub Actions Inactive

duranb temporarily deployed to test-workflow

June 7, 2024 17:13

— with

GitHub Actions Inactive

duranb had a problem deploying to test-workflow

June 7, 2024 20:29

— with

GitHub Actions Failure

duranb temporarily deployed to test-workflow

June 7, 2024 22:33

— with

GitHub Actions Inactive


          first pass expose post model upload errors to upload page

c729255

duranb added 19 commits

June 12, 2024 10:36


          add ModelErrors console to plan

b35a473


          fix model error count on load

fd7ffac

display error on console model error open
prettify JSON errors


          add model error bar to plan page

d7fdb43

reflow layout to be more flexible


          fix page layout overflow

81f228d


          add ModelErrors test

186b379


          update ModelErrors test title


          move store reset in model form

d17636e


          add ModelStatusIcon tests

5053d07


          add ModelStatusRollup tests

9cc0125


          add util function for getting model status rollup

fd0e893

add model status to plan page


          fix model dropdown binding

df9732c


          Updated model creation tests to account for model status

32505e7


          increase gap between icon and model status

06860e7

move tooltip around whole status


          update model error bar to match design

e20b24e


          prevent unnecessary field updates

60aa2d9


          fix lint

5f12211


          Sort subscribed models order by descending ID

34b4b5f

Add "key" to #each on model select


          only show error message if present

772b8c2


          fix status desync in table when model status is updated via socket

564c704

duranb force-pushed the feature/model-upload-errors branch from ae7159b to 564c704 Compare

June 12, 2024 17:37

duranb temporarily deployed to test-workflow

June 12, 2024 17:37

— with

GitHub Actions Inactive

AaronPlave reviewed

View reviewed changes

src/components/model/ModelStatusRollup.svelte Outdated Show resolved Hide resolved

AaronPlave approved these changes

View reviewed changes

Contributor

AaronPlave left a comment

Just a few more comments but otherwise LGTM, nice work!

duranb added 2 commits

June 12, 2024 19:07


          display model extraction success message

e66d795


          apply typography styles

22e91e9

duranb temporarily deployed to test-workflow

June 13, 2024 02:07

— with

GitHub Actions Inactive

duranb merged commit 00dc552 into develop

5 checks passed

duranb deleted the feature/model-upload-errors branch

June 13, 2024 02:16

JosephVolosin pushed a commit that referenced this pull request


          Expose model upload errors (#1319)

aa11737

* add ModelStatusRollup component
* display model status on models list page
* add model status to model edit form
* add ModelErrors console to plan
* add model error bar to plan page

JosephVolosin pushed a commit that referenced this pull request


          Expose model upload errors (#1319)

c6a102c

* add ModelStatusRollup component
* display model status on models list page
* add model status to model edit form
* add ModelErrors console to plan
* add model error bar to plan page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AaronPlave AaronPlave approved these changes

dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Labels

feature