Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test flakiness fixes #1343

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jun 20, 2024

No description provided.

@duranb duranb requested a review from a team as a code owner June 20, 2024 23:07
@duranb duranb force-pushed the tests/another-small-round-of-anti-flaking branch from 17c6eab to 37d3f29 Compare June 21, 2024 18:30
@AaronPlave
Copy link
Contributor

I think we need to abort stale getEffectiveActivityArguments requests in order to properly manage the excess chain reaction here, I'll make an issue for it.

wait for argument error to clear before moving on to next argument in tests
use better selectors in app-nav tests
@duranb duranb force-pushed the tests/another-small-round-of-anti-flaking branch from aa3ddac to e7d0a6d Compare June 26, 2024 15:54
@duranb duranb merged commit f4fdff0 into develop Jun 26, 2024
5 checks passed
@duranb duranb deleted the tests/another-small-round-of-anti-flaking branch June 26, 2024 16:17
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* reduce chances of too many updates by aborting argument updates
* ignore AbortError from error logs
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* reduce chances of too many updates by aborting argument updates
* ignore AbortError from error logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants