-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/seqgen grammar v2 #1362
Feat/seqgen grammar v2 #1362
Conversation
@joswig I see ground epochs have been implemented like so:
I propose that we instead support ground epochs at the same level that we support absolute/relative/command complete times like so:
I added a space between the E and the epoch name because otherwise you end up with ENAME+03:00:00 which isn't the most readable. Maybe this is why you went with @GROUND_EPOCH instead? I do think we should try to have the ground epoch time tag match the format of the other time tags if possible. We should also support using ground epochs not just with request start times, but also on any random command, such as:
|
What guarantees do we have on delta format? String is in the schema |
We will address ground epoch update with the implementation of ground epoch time tags for commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On thing to note is we don't have the autocomplete hooked up. Not sure if you want to do that later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok if we hold off on merging this? I would like to prioritize @cohansen's refactor first. I don't expect to see many conflicts other than the globals change.
* grammar test cleanup * error cleanup * alternate syntax for seqgen constructs * serialization and highlighting for load, activate, ground_block, ground_event * Round trip support for activate, load, ground event, ground block, request * corrected relative time format typo * merge in updates for string handling from develop * merge in grammar tests from develop * merged in fixes for quoted symbols and missing new lines * run prettier * include day separator * move time format code, simple selected step support * Generate lint errors on non command constructs unless enabled in adaptation * allow non-command steps by default * remove wip vml * color highlighting for ground epoch * Don't add space between consecutive CAPITAL letters
* grammar test cleanup * error cleanup * alternate syntax for seqgen constructs * serialization and highlighting for load, activate, ground_block, ground_event * Round trip support for activate, load, ground event, ground block, request * corrected relative time format typo * merge in updates for string handling from develop * merge in grammar tests from develop * merged in fixes for quoted symbols and missing new lines * run prettier * include day separator * move time format code, simple selected step support * Generate lint errors on non command constructs unless enabled in adaptation * allow non-command steps by default * remove wip vml * color highlighting for ground epoch * Don't add space between consecutive CAPITAL letters
Closes #1361