Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anchor directive start time computation #1390

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix anchor directive start time computation #1390

merged 1 commit into from
Jul 19, 2024

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Jul 19, 2024 •
edited
Loading

Fixes issue where the start time computation for an anchored directive was mistakenly being assigned to the anchor directive.

Closes #1337

Testing:

  1. Make a plan
  2. Create a chain of anchored activities with varied offsets
  3. Drag activities around and verify that anchored relationships update as expected

@AaronPlave AaronPlave requested a review from a team as a code owner July 19, 2024 20:04
@AaronPlave AaronPlave self-assigned this Jul 19, 2024
duranb
duranb approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find! lgtm!

@AaronPlave AaronPlave merged commit a05ac61 into develop Jul 19, 2024
5 checks passed
@AaronPlave AaronPlave deleted the fix/1137/anchor-directive-start-time-fix branch July 19, 2024 20:27
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
Fix anchor directive start time computation (#1390)
3c53739 
Assign the computed anchored directive start time to the anchored directive and not the anchor directive
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave
Fix anchor directive start time computation (#1390)
2fda1e0 
Assign the computed anchored directive start time to the anchored directive and not the anchor directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving a directive that has another directive anchored results in incorrect start times
2 participants
@AaronPlave @duranb