Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-populate end time with start time during plan creation #354

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Pre-populate end time with start time during plan creation #354

merged 1 commit into from
Jan 25, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jan 24, 2023

Resolves #347

To test:

  1. Go to plan creation page
  2. Enter valid start time
  3. Verify that end time is now the same as the start time
  4. Clear out both inputs
  5. Enter an invalid start time
  6. Verify that the end time does not get updated until a valid start time is provided

@duranb duranb added the feature New feature or request label Jan 24, 2023
@duranb duranb requested a review from a team as a code owner January 24, 2023 00:06
@duranb duranb temporarily deployed to test-workflow January 24, 2023 00:06 — with GitHub Actions Inactive
@duranb duranb mentioned this pull request Jan 25, 2023
Closed
@duranb duranb force-pushed the feat/prepopulate-plan-end-time branch from 48112ec to 3f958b8 Compare January 25, 2023 20:22
@duranb duranb temporarily deployed to test-workflow January 25, 2023 20:22 — with GitHub Actions Inactive
@duranb duranb merged commit 5ba2450 into develop Jan 25, 2023
@duranb duranb deleted the feat/prepopulate-plan-end-time branch January 25, 2023 20:32
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Pre-populate end time with start time during plan creation (#354)
97a10cf 
feat: update end time input with start time when valid start time is provided for plan creation
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb
Pre-populate end time with start time during plan creation (#354)
bb20ff3 
feat: update end time input with start time when valid start time is provided for plan creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@camargo camargo Awaiting requested review from camargo camargo is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan create end time date picker not starting at start time
2 participants
@duranb @AaronPlave