Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add css class name kebab case lint rule #555

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Add css class name kebab case lint rule #555

merged 2 commits into from
Apr 4, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Apr 3, 2023

No description provided.

@duranb duranb added the refactor A code change that neither fixes a bug nor adds a feature label Apr 3, 2023
@duranb duranb requested a review from a team as a code owner April 3, 2023 21:59
@camargo camargo changed the title Refactor: Add css class name kebab case lint rule Add css class name kebab case lint rule Apr 3, 2023
@duranb duranb temporarily deployed to test-workflow April 3, 2023 23:05 — with GitHub Actions Inactive
camargo
camargo approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duranb duranb force-pushed the refactor/kebab-case-css-classes branch from fed689d to 9b8e171 Compare April 4, 2023 19:26
@duranb duranb temporarily deployed to test-workflow April 4, 2023 19:26 — with GitHub Actions Inactive
@camargo camargo added the style Changes that do not affect the meaning of the code (white-space, formatting, etc) label Apr 4, 2023
@duranb duranb merged commit 609b57c into develop Apr 4, 2023
@duranb duranb deleted the refactor/kebab-case-css-classes branch April 4, 2023 19:37
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Add css class name kebab case lint rule (#555)
f97393d 
* add css class name kebab case lint rule
* fix class names that violate new rule
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb
Add css class name kebab case lint rule (#555)
c1a3c9f 
* add css class name kebab case lint rule
* fix class names that violate new rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@duranb duranb

Labels
refactor A code change that neither fixes a bug nor adds a feature style Changes that do not affect the meaning of the code (white-space, formatting, etc)
Projects
Aerie
Archived in project
Milestone
FY23 Q2 - UI Ad Hoc Improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@duranb @camargo