Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AERIE-1873] feat: ag-grid table implementation #67

Merged
merged 12 commits into from
Jul 25, 2022

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jul 21, 2022

This resolves https://jira.jpl.nasa.gov/browse/AERIE-1933.

It includes a generic ag-grid table component and replaces the Activities, Constraints, and Scheduling Goals tables.

src/css/table.css Outdated Show resolved Hide resolved
src/css/table.css Outdated Show resolved Hide resolved
@camargo
Copy link
Member

camargo commented Jul 21, 2022

Is it easy to remove the individual cell highlighting for now?
Screen Shot 2022-07-21 at 2 17 30 PM

@duranb duranb force-pushed the feat/AERIE-1873-generic-table branch 2 times, most recently from 7ac007d to f7e4794 Compare July 22, 2022 00:08
added ag-grid DataGrid component (wip)
added DataGridActions component for common custom actions across tables
replaced ActivityTable's and Constraints' Table component with new DataGrid component
Add better type definitions for grid columns
@duranb duranb force-pushed the feat/AERIE-1873-generic-table branch from 0e44ce2 to 96315c1 Compare July 25, 2022 18:23
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean code! LGTM

@duranb duranb merged commit 85a15cd into develop Jul 25, 2022
@duranb duranb deleted the feat/AERIE-1873-generic-table branch July 25, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants