-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AERIE-1873] feat: ag-grid table implementation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camargo
reviewed
Jul 21, 2022
camargo
reviewed
Jul 21, 2022
camargo
reviewed
Jul 21, 2022
duranb
force-pushed
the
feat/AERIE-1873-generic-table
branch
2 times, most recently
from
July 22, 2022 00:08
7ac007d
to
f7e4794
Compare
added ag-grid DataGrid component (wip)
added DataGridActions component for common custom actions across tables replaced ActivityTable's and Constraints' Table component with new DataGrid component
Add better type definitions for grid columns
duranb
force-pushed
the
feat/AERIE-1873-generic-table
branch
from
July 25, 2022 18:23
0e44ce2
to
96315c1
Compare
camargo
reviewed
Jul 25, 2022
camargo
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean code! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves https://jira.jpl.nasa.gov/browse/AERIE-1933.
It includes a generic ag-grid table component and replaces the Activities, Constraints, and Scheduling Goals tables.