Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respond to changes in device pixel ratio for canvas components #701

Merged
merged 8 commits into from
Jun 12, 2023
Merged

Respond to changes in device pixel ratio for canvas components #701

merged 8 commits into from
Jun 12, 2023

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Jun 9, 2023 •
edited
Loading

Closes #682

  • Store and update device pixel ratio on change within Timeline.svelte
  • Use the new responsive dpr in Layer* canvas components

TODO:

  • Use responsive dpr in LayerGaps

Testing:

  1. Open a plan with activities, a line layer, an x-range layer, and a line layer with external resource gaps (see Render external dataset with profile gaps #607 for directions on how to add a sample profile with gaps)
  2. Drag the window to a screen with a higher DPR than the current screen
  3. The canvas elements should not appear blurry

@AaronPlave AaronPlave temporarily deployed to test-workflow June 9, 2023 19:10 — with GitHub Actions Inactive
@AaronPlave AaronPlave self-assigned this Jun 9, 2023
@AaronPlave AaronPlave added the fix A bug fix label Jun 9, 2023
@AaronPlave AaronPlave temporarily deployed to test-workflow June 9, 2023 19:14 — with GitHub Actions Inactive
@AaronPlave AaronPlave temporarily deployed to test-workflow June 9, 2023 19:19 — with GitHub Actions Inactive
@AaronPlave AaronPlave marked this pull request as ready for review June 9, 2023 19:19
@AaronPlave AaronPlave requested a review from a team as a code owner June 9, 2023 19:19
@AaronPlave AaronPlave temporarily deployed to test-workflow June 9, 2023 19:38 — with GitHub Actions Inactive
camargo
camargo approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@AaronPlave AaronPlave temporarily deployed to test-workflow June 12, 2023 18:12 — with GitHub Actions Inactive
@camargo camargo merged commit a081120 into develop Jun 12, 2023
@camargo camargo deleted the fix/682/dpr-responsivity branch June 12, 2023 19:19
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
Respond to changes in device pixel ratio for canvas components (#701)
c1ff4da 
* Use dpr value in canvas components
* Use responsive dpr in LayerGaps
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave
Respond to changes in device pixel ratio for canvas components (#701)
0babc5f 
* Use dpr value in canvas components
* Use responsive dpr in LayerGaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@duranb duranb Awaiting requested review from duranb duranb is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canvas rendering should respond to DPR changes
2 participants
@AaronPlave @camargo