-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cognito Layer Automated Deployment Update #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd tips on how to solve them. -Modified Documentation to include the new terraform module post-deploy-mods which is used for patching or over-writing any existing items that need to be overwritten. -Modified Documentation to include more detailed information about the cognito layer system and the vendor EULA filter. -Modified the Makefile to include a call to a function that zips lambdas to prepare them for deployment. -Added a script that will zip up the lambda function so it is ready for deployment. -Added the lambda python code that makes up the vendor filter. -Added a new module post-deploy-mods including a main.tf and base.tfvars file. This module uploads the new lambda function, and then positions itself inside the proxy section of the API Gateway for the DistributionAPI. The existing lambda function stays intact as it is called by the new lambda function. -Added a silent directive inside of base.tfvars to ensure this new module deploys AFTER the other 3 have completed. If this module deploys in a different order, it will not function properly. -Also added a stacks.rb file to the config to ensure all of the modules deploy in the correct order. -Added the module name to the terraform doctor command and the comment of the terraform doctor script. #655
jsrikish
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed in my sandbox env. Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cognito Layer / Vendor Filtering Automated Deployment Update
Ticket Reference: https://github.com/NASA-IMPACT/csda-project/issues/655
This update introduces a 4th module to the deployments, a
post-deploy-mods
module which uploads a new lambda function for the purpose of filtering download requests by Vendor EULA confirmations.This deployment uploads and inserts the new lambda into the API Gateway.
I've also added some documentation about how the Cognito Integration functions.
To test the deployment in sandbox follow these steps
Change / Commit Notes Below