-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag ".." in <file_name> as error condition #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v. nice
Thanks @alexdunnjpl @c-suh! 🎉 |
@nutjob4life thank you for the quick turnaround! Much appreciated. |
@nutjob4life question: does deep-archive provide any support for directory_path_name? according to the spec, this is how someone could specify a path to a file not in the current directory. |
@jordanpadams that attribute doesn't explicitly allow for relative paths either (as it also requires a root/cwd to be meaningful, which isn't mentioned)... was it definitely intended to support relpaths? |
@jordanpadams there is support for deep-archive/src/pds2/aipgen/utils.py Lines 200 to 204 in b398f8d
|
@alexdunnjpl I was thinking the same thing. you can start getting really weird with things like |
🗒️ Summary
Merge this to have
pds-deep-archive
raise an exception when encountering<file_name>
entries that contain relative paths, such as../catalog/dataset.cat
, which according to this comment is invalid in a PDS label.⚙️ Test Data and/or Report
Before:
After:
♻️ Related Issues