Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106 add explanatory text to skipped product log message (addendum to PR#109) #121

Merged
merged 2 commits into from
May 1, 2023

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

#109 was incomplete, due to lack of understanding of codebase at the time and failure to comprehensively test change

⚙️ Test Data and/or Report

Manually tested.

♻️ Related Issues

Fixes #106
Completes #109

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Sean's comment

src/main/java/gov/nasa/pds/harvest/dao/MetadataWriter.java Outdated Show resolved Hide resolved
@alexdunnjpl
Copy link
Contributor Author

Oh, good call - I'm so used to autoparsing it that I totally missed it. Will fix now.

@tloubrieu-jpl
Copy link
Member

@alexdunnjpl Note also that "is" was duplicated also in the message line 23

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexdunnjpl

@alexdunnjpl alexdunnjpl merged commit 2d8afeb into main May 1, 2023
@alexdunnjpl alexdunnjpl deleted the 106-addendum branch May 1, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve skipped product INFO message
3 participants