Add URL Routing #52 #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added react router to simulate pages and allow navigation button use.
c-suh
reviewed
Jun 21, 2021
| @@ -100,111 +102,112 @@ const SearchResults = () => { | |||
| // }, [props.data, props.table]); | |||
|
|
|||
| return ( | |||
| <> | |||
| <div> | |||
| results | |||
There was a problem hiding this comment.
I'm assuming the word "results" is a forgotten placeholder?
|
@eddiesarevalo other than the one line about which I commented above, this looks good! I will remind @tloubrieu-jpl at the next meeting about open pull requests as he is the one with write access and can approve merging. |
c-suh
approved these changes
Jun 22, 2021
tloubrieu-jpl
approved these changes
Jun 22, 2021
|
@eddiesarevalo are you able to address the one comment @c-suh raised above? |
|
Merged in branch routing-fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added react router to simulate pages and allow navigation button use.
resolves #52