-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud front function updates for version 1.2.0, makes swagger-ui work on AWS #333
Conversation
Sorry I messed with my rebase, and for some reason we see updates on the github actions in my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nitpicks
.github/workflows/stable-cicd.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if you can be bothered to revert this change, then squash the change commit and revert commit with another commit (thereby making the change/revert cancel each other out and become invisible), that's preferable, but not important
.github/workflows/unstable-cicd.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if you can be bothered to revert this change, then squash the change commit and revert commit with another commit (thereby making the change/revert cancel each other out and become invisible), that's preferable, but not important
if (debug) console.log("incoming URI includes a command") | ||
|
||
// at a minimum service, version and command are required, otherwise fall through w/o changes | ||
//if (uriParts.length > CMD_IDX && uriParts[CMD_IDX].trim() != "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove if not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping these changes
🗒️ Summary
The cloudfront function used to add headers to the incoming request has been updated and tested.
♻️ Related Issues
completes #331