Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud front function updates for version 1.2.0, makes swagger-ui work on AWS #333

Merged
merged 8 commits into from
May 11, 2023

Conversation

tloubrieu-jpl
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl commented May 3, 2023

🗒️ Summary

The cloudfront function used to add headers to the incoming request has been updated and tested.

♻️ Related Issues

completes #331

@tloubrieu-jpl tloubrieu-jpl changed the title Add cloud front function updates for version 1.2.0 & swagger-ui to work Add cloud front function updates for version 1.2.0, makes swagger-ui work on AWS May 3, 2023
@tloubrieu-jpl tloubrieu-jpl marked this pull request as draft May 3, 2023 21:37
@tloubrieu-jpl
Copy link
Member Author

Sorry I messed with my rebase, and for some reason we see updates on the github actions in my PR.

@tloubrieu-jpl tloubrieu-jpl marked this pull request as ready for review May 3, 2023 21:43
Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nitpicks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if you can be bothered to revert this change, then squash the change commit and revert commit with another commit (thereby making the change/revert cancel each other out and become invisible), that's preferable, but not important

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if you can be bothered to revert this change, then squash the change commit and revert commit with another commit (thereby making the change/revert cancel each other out and become invisible), that's preferable, but not important

if (debug) console.log("incoming URI includes a command")

// at a minimum service, version and command are required, otherwise fall through w/o changes
//if (uriParts.length > CMD_IDX && uriParts[CMD_IDX].trim() != "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove if not required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping these changes

@tloubrieu-jpl tloubrieu-jpl merged commit c35e93f into main May 11, 2023
@tloubrieu-jpl tloubrieu-jpl deleted the fix_aws_1.2.0 branch May 11, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants