Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with returning members of a bundle #359

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix bug with returning members of a bundle #359

merged 2 commits into from
Jul 17, 2023

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Jul 11, 2023 •
edited
Loading

🗒️ Summary

Added lidvids to the return list

⚙️ Test Data and/or Report

$ curl -X GET 'http://localhost:8080/products/urn:nasa:pds:mars2020.spice::3.0/members'
{"summary":{"q":"","hits":2,"took":60,"start":0,"limit":100,"sort":[],...

with the important bit being 2 hits

♻️ Related Issues

Closes #341
Closes #355

@al-niessner al-niessner mentioned this pull request Jul 11, 2023
Closed
alexdunnjpl
alexdunnjpl approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short enough that I'm happy to rubber-stamp without getting up to speed on the context - I trust you!

@jordanpadams jordanpadams changed the title Issue 341: return bundle members Fix bug with returning members of a bundle Jul 17, 2023
@jordanpadams jordanpadams merged commit 68052fc into main Jul 17, 2023
@jordanpadams jordanpadams deleted the issue_341 branch July 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdunnjpl alexdunnjpl alexdunnjpl approved these changes

@tloubrieu-jpl tloubrieu-jpl Awaiting requested review from tloubrieu-jpl tloubrieu-jpl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@al-niessner @alexdunnjpl @jordanpadams