Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking a Mac dev to maintain NTRT's mac builds. #143

Open
PerryBhandal opened this issue Mar 19, 2015 · 12 comments
Open

Seeking a Mac dev to maintain NTRT's mac builds. #143

PerryBhandal opened this issue Mar 19, 2015 · 12 comments

Comments

@PerryBhandal
Copy link
Member

We're currently seeking a Mac dev who can help maintain NTRT on OS X systems. NTRTSim is currently broken for OS X, so that's the immediate concern. Once we have it working, we would like someone who can help ensure it remains that way!

@jerryderry
Copy link

Is this mac dev still needed?

@PerryBhandal
Copy link
Member Author

Yep!

There is, admittedly, less activity/support around the project nowadays. That might make this a bit more challenging, but anyone who wants to give it a shot is welcome to do so.

@jerryderry
Copy link

NTRT can now be built on macOS 10.12. I have forked the repository, but I changed a lot to make it work, and I didn't write any code checking platforms. So I'm not sure if I should pull request, as it may not be built on Linux.

@PerryBhandal
Copy link
Member Author

That's great to hear. Thanks for investing the effort.

I'm concerned about pulling the code into the main repo without some certainty that it isn't broken for existing users. We have a fairly significant restructuring coming with v1.2 (main difference is that NTRT will act more as a library/framework, and applications will be kept in separate repos) so we might be able to bring that in then.

I've started a build of your code on Linux (Mint 18.2) and will report back on whether it was successful, then we can go from there.

@jerryderry
Copy link

I'm glad it will change into a framework. I actually hope that NTRT could be a proper application, where you build your models, visualize them, do simulations, check internal forces, etc, all in this application, without writing separate c++ files. And not just be used for robotics. I guess more like a universal platform.

@PerryBhandal
Copy link
Member Author

The build ended up failing on the NeuralNet setup step. The output can be found here:

https://gist.githubusercontent.com/PerryBhandal/18028846214b96020586862130f35652/raw/5a8d6c5741d2f661a8f05427893f5c360e2ff8c4/gistfile1.txt

I'd say our best path forward is to try and return OS X support with version 1.2. I can keep you in the loop on when that is happening/once the migration plan is more firm and from there we can sort out how to integrate your changes in a stable manner.

It will likely be some time before that migration happens, unless one of the other devs is able to handle it.. My plan is to continue working on the v1.2 transition after November 18th with an aim of having the migration complete before the end of the year. It's possible that some other dev might take on the work of finishing the migration so it might be doable sooner, but that doesn't seem likely given how busy everyone is at the moment.

I'll get in touch once we're closer to the migration and we can go from there. It'll be great if we can have someone managing the OS X side, so hopefully you'll have the time/interest then.

@jerryderry
Copy link

I see what's going on with NeuralNet. In the original patches, there are plenty of codes that use tr1 to generate random numbers. And this is before c++11 standard. Most of the functions are now in c++11. But on mac, the standard library doesn't ship with tr1, so clang can't recognize it, and the files have to be changed to conform c++11. That's why in the error message, it's saying you need to use -std=c++11 to flag the compiler.

Perhaps you may want to change the function build_neuralnet() in the file setup_neuralnet.sh, and modify to -DCMAKE_CXX_FLAGS="-std=c++11" \?

@PerryBhandal
Copy link
Member Author

I can give that a shot shortly, but even if it can be made to compile it's probably wise to wait until 1.2 to return OS X support. One of the big problems with NTRT so far (and something we'll hopefully do a better job of in 1.2 and beyond) has been a lack of focused testing/QA. Often modifications are just merged into the master after a brief glance which has made the process of maintenance/ensuring stability more challenging.

@jerryderry
Copy link

Yes that's fine by me. At least I have a working one for myself.

I agree with testing. Another issue is that I think more tutorials are needed. I've tried NTRT 3 years ago, but I still don't know how to use it. For example, I have no idea why the structure keeps vibrating even without controllers.

@PerryBhandal
Copy link
Member Author

No doubt that better tutorials are needed. The documentation in general could be far better, and hopefully make NTRT more accessible.

I believe there was a thread about the vibrating issue on the mailing list. I'll take a look once I'm home and if I can find the specific thread I'll forward you a copy of it.

@apsabelhaus
Copy link
Member

apsabelhaus commented Sep 12, 2017 via email

@jerryderry
Copy link

Thanks guys, I'll have a scan of the archive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants