Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Edition #81

Open
wcmatthysen opened this issue Jan 8, 2017 · 64 comments
Open

Community Edition #81

wcmatthysen opened this issue Jan 8, 2017 · 64 comments

Comments

@wcmatthysen
Copy link

wcmatthysen commented Jan 8, 2017

There is a need for a community edition of WorldWind. This will essentially be a community-managed fork that incorporates pull requests not belonging in the stable upstream version, but still being useful enough to the community that it should be maintained and kept up-to-date. See the discussion at pull-request #77 for some background on this.

@quonn77
Copy link

quonn77 commented Jan 12, 2017

I agree with you, there is a lot of work that risk to be abandoned. I have improvement for handling HTTP Redirection, drawing ground line for air track, increase detail rendering of 2D maps so it would be nice to have a common shared community fork where all those improvements could be available. If I can help, I am available.

@wcmatthysen
Copy link
Author

wcmatthysen commented Jan 12, 2017

Good, I think we need a lot of people on-board to get the community-edition going. But, first we have to wait for the NASA guys to post the community contribution guidelines (this was mentioned in pull-request #77). The pull-request labels will be needed to determine what pull-requests are fit for the community-fork. In your case, you would probably have to then create pull-requests for the various additions in this repository. If it should go to the community-fork the NASA guys will then mark it with a label "community-edition" (or whatever label is decided) where it will then be picked up by the community-fork owners and merged into that repository.

@quonn77
Copy link

quonn77 commented Jan 12, 2017

I believe, as already stated on the pull-request-77 that the community fork needs some members of the board from the NASA Team so we can better coordinate integration of derivative work into stable nwwj product.

@pdavidc
Copy link
Contributor

pdavidc commented Jan 12, 2017

@wcmatthysen Thanks for opening a dedicated issue for this discussion.

The NASA team is certainly on board with a coordinated community fork. We're very busy at the moment working on sponsored feature deliverables for the Android and Web SDKs, but have this on our Kanban board to address as soon as we can.

@wcmatthysen
Copy link
Author

@pdavidc Any news? Would love to get started working on this.

@pdavidc
Copy link
Contributor

pdavidc commented Feb 3, 2017

Thanks for your patience. We haven't forgotten about this need. It's on our backlog of tasks to address after we finish our current round of sponsor-requested features.

@pdavidc pdavidc removed the request label Jun 16, 2017
@wcmatthysen wcmatthysen mentioned this issue Sep 24, 2018
@wcmatthysen
Copy link
Author

I think a community edition is now more relevant than ever (just my 2 cents).

@quonn77
Copy link

quonn77 commented Apr 5, 2019 via email

@wcmatthysen
Copy link
Author

We do not need NASA's permission as far as I understand. It is open-source after all. We can just fork it and go our separate ways. It would be great to get their blessing though.

@wcmatthysen
Copy link
Author

I see there is already an official community fork for WebWorldWind. Maybe we can reach out to @emxsys to host the community edition of WorldWindJava under the WorldWindEarth banner as well.

@arihunta
Copy link

arihunta commented Apr 5, 2019

Sounds good--I somehow totally missed the announcement of the suspension of the WorldWind projects.

I'd be happy to lend a hand if there's anything needed to get this initiative off the ground.

@caller
Copy link

caller commented Apr 5, 2019

perfect. we would be in as well. we have quite some potential contribution, (e.g. javaFX port) but since nasa was too refusive on merging anything, we gave up.

@wcmatthysen
Copy link
Author

wcmatthysen commented Apr 5, 2019

I think we should set up a rough road-map of what we want to accomplish. I would personally like to switch the project's build system over to Maven (or Gradle for that matter) instead of the clunky, archaic way that they have built the project using Ant. I have managed to do that in my own fork of the project, so it can be done with a bit of effort. I think the JavaFX additions would be great seeing as that is where everything is moving towards nowadays. We could probably go through the current pull request list and merge a lot of the useful ones into our own version. Bug-fixes should take priority. We can also focus some effort on modernising the project by introducing some Java 8 features as we go along.

I don't know how we can increase the visibility on this issue, seeing as it is quite old. It doesn't show up at the top of the issue-list on the project's GitHub page. We need to get the word out to as many other people that are interested as possible or this is not going to take off. I tried to get the fork going a year or two ago but no-one was really interested. You can see my post here on the forums as well (it never got any real traction).

@wcmatthysen
Copy link
Author

wcmatthysen commented Apr 5, 2019

I think two pull requests that we should already consider a priority is the JOGL upgrade (see pull-request #1) and the GDAL upgrade (see pull-request #146). I mean the JOGL pull request has been waiting for a merge now for over 3 years.

@wcmatthysen
Copy link
Author

These pull-requests: #18, #19, #30, #138, #139 that are bug-fixes have also been unmerged for roughly 2 to 3 years now. Not to mention the more recent pull-requests such as #150 and #157 that should probably be inspected and merged.

@kotogadekiru
Copy link

kotogadekiru commented Apr 5, 2019 via email

@wcmatthysen
Copy link
Author

wcmatthysen commented Apr 5, 2019

A community edition with an updated design would be great, count me in for what is worth. I think a javafx por would be great. I don't know if a javafx version would use jogl. Also maven would be great! If someone builds it, we will follow :) Cheers, Tomas Lund Petersen El vie., 5 abr. 2019 09:14, Wiehann Matthysen notifications@github.com escribió:

I think two pull requests that I would already consider a priority is the JOGL upgrade (see issue #1 <#1>) and the GDAL upgrade (see issue #146 <#146>). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#81 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_pYAATm6AVFSIWtjxkep1s_xuWHjdeks5vdz4qgaJpZM4Ldu1G .

Not sure about the JavaFX port either. I know that JavaFX has its own 3D API. I haven't personally worked with it. I am not sure whether work has already been done to port WorldWind to run in JavaFX. But any contributions with respect to that would be a welcome addition to the community edition. I know it can at least be embedded in a SwingNode and displayed in a JavaFX application (but that is different than porting it to JavaFX's 3D API).

I think we should just find a proper home for this project. It would probably be best if it lives alongside the other community editions, hence the reason I mentioned Bruce Schubert's (@emxsys) community fork of WebWorldWind.

@kotogadekiru
Copy link

kotogadekiru commented Apr 5, 2019 via email

@wcmatthysen
Copy link
Author

wcmatthysen commented Apr 5, 2019

I also think we should concentrate on providing replacement for the basemap layers that point to the nasa servers that are going down may 4rth. Bing aereal, sentinel2, places and roads seems to me te most importants. I guess elevations would be important to some people also. Cheers, Tomas El vie., 5 abr. 2019 09:33, Tomas Lund Petersen kotogadekiru@gmail.com escribió:

A community edition with an updated design would be great, count me in for what is worth. I think a javafx por would be great. I don't know if a javafx version would use jogl. Also maven would be great! If someone builds it, we will follow :) Cheers, Tomas Lund Petersen El vie., 5 abr. 2019 09:14, Wiehann Matthysen @.***> escribió: > I think two pull requests that I would already consider a priority is the > JOGL upgrade (see issue #1 > <#1>) and the GDAL > upgrade (see issue #146 > <#146>). > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#81 (comment)>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AB_pYAATm6AVFSIWtjxkep1s_xuWHjdeks5vdz4qgaJpZM4Ldu1G > . >

Yes, I think that is also important. I have a Sentinel2 layer configuration file that I can share to replace the LandSat layer. It connects directly to the EOX::Maps server to get the s2cloudless layer. I don't know about an OpenStreetMap layer that we can use. Maybe we can get a layer from EOX::Maps as well. The elevation data is very important. I don't know if the NASA guys have made any plans to host it somewhere else. It would be nice to at least get some info on how to setup and host the data ourselves.

@arihunta
Copy link

arihunta commented Apr 5, 2019

Again, all sounds good. Merging in pull request #1, a Gradle build, and alternative base layers would all be great. Not so sure about JavaFX, both because of OpenGL issues, and its exclusion from future JDKs, but I'm not too clued up on that stuff. Might be best to make anything that relies on JavaFX a separate optional module?

As for visibility, it might be worth bumping your original thread in the forum, and posting on this one as well: https://forum.worldwindcentral.com/forum/world-wind-community/worldwind-general/158839-worldwind-suspension.

Though, once a home for this project has been found then issues/features can be decided upon & tracked there, and that location can be advertised. Probably worth dropping @emxsys an e-mail to get his thoughts, if he hasn't already gotten notifications from being tagged here, and then moving forward from there.

@caller
Copy link

caller commented Apr 5, 2019

so our JavaFX port works in parallel to the Swing components. so no issue. it also uses openGL.
we also have our own jogl and GDAL patches.... as probably most of you.
and we are also on maven...
we even have tried to file fundamentaly bugs like a math bug in matrix determinant computation... and they havent picked it...

@caller
Copy link

caller commented Apr 5, 2019

#155

@kotogadekiru
Copy link

kotogadekiru commented Apr 5, 2019 via email

@quonn77
Copy link

quonn77 commented Apr 5, 2019

Yes I think that we need to create separated module of the Nasa World Wind SDK, isolating math-projection library, common utility to the core features

@quonn77
Copy link

quonn77 commented Apr 5, 2019

So which are the next steps? Some one has get in touch with Bruce Schubert's?

@caller
Copy link

caller commented Apr 5, 2019

we havent polished our javaFX version jet for release... that might take some weeks in our processes. I might also need mgmt approval. Im working for a quite big company ;-)

@wcmatthysen
Copy link
Author

Again, all sounds good. Merging in pull request #1, a Gradle build, and alternative base layers would all be great. Not so sure about JavaFX, both because of OpenGL issues, and its exclusion from future JDKs, but I'm not too clued up on that stuff. Might be best to make anything that relies on JavaFX a separate optional module?

As for visibility, it might be worth bumping your original thread in the forum, and posting on this one as well: https://forum.worldwindcentral.com/forum/world-wind-community/worldwind-general/158839-worldwind-suspension.

Though, once a home for this project has been found then issues/features can be decided upon & tracked there, and that location can be advertised. Probably worth dropping @emxsys an e-mail to get his thoughts, if he hasn't already gotten notifications from being tagged here, and then moving forward from there.

I bumped some threads in the forum. I think Bruce Schubert would probably be notified via GitHub as a result of all the mentions. I'll email him too just in case.

@mainstringargs
Copy link

mainstringargs commented Apr 5, 2019

Just getting up to speed on this -- does this fork already exist? I love what you guys are thinking. Having JavaFX capability but also keeping the Swing parts working would be perfect.

Some other good (free) WMS layers are available here:

https://developer.earthdata.nasa.gov/gibs/gibs-api-for-developers

Although it requires updating the WMSTiledImageLayer to capitalize the url query parameters:

https://github.com/nasa/World-Wind-Java/blob/7c9886ab67ac03d53bdb04f161b9605d3f3dd810/WorldWind/src/gov/nasa/worldwind/wms/WMSTiledImageLayer.java#L189

@mainstringargs
Copy link

And I vote for gradle

@PJHogan
Copy link

PJHogan commented Apr 5, 2019 via email

@wcmatthysen
Copy link
Author

Bruce got back to me and mentioned that we can host the Java version of the community-fork on WorldWindEarth (that is: https://github.com/WorldWindEarth).

@PJHogan
Copy link

PJHogan commented Apr 6, 2019 via email

@PJHogan
Copy link

PJHogan commented Apr 6, 2019

NASA Ames Research Center, where the WorldWind project has been continuously hosted since 2002 had proposed a suspension of the project, but the kick-back from other Federal agencies 'encouraged' a reconsideration. So NASA is back-in-the-saddle with regard to the WorldWind project. The suspension has now been 'suspended' for a month (until May 3), but it will likely stay alive and well ad infinitum. That is not to suggest the community should not take this opportunity to accelerate this technology 'to infinity and beyond!' Controlling our own destiny so to speak, with a community effort at a global scale. This will be beautiful, and show what's possible when working in concert 'for the benefit of all.'

@wcmatthysen
Copy link
Author

@PJHogan, I agree. I think we should go forward with a community-fork irrespective of the suspension (or the suspension of the suspension). That is, if we can get a community fork going. A community fork could be very fruitful in my opinion in the long run, seeing as there are a lot of developers using WorldWind and benefiting from its continued development (myself included). I also pick up that there are developers that are very willing to contribute code-changes to WorldWind, but the way in which pull-requests and bug-fixes on this project has been managed the last couple of years has been very frustrating to say the least. That is not to say that myself and everyone using WorldWind are very grateful towards NASA and its developers for releasing WorldWind as an open-source project. I just think that going forward, the fork itself should be lead by the community.

@PJHogan
Copy link

PJHogan commented Apr 6, 2019

Wiehann, of course!
And I think forks can also feed each other. :~}
Bruce has generously offered to host ^it^ at https://github.com/WorldWindEarth/
I think that would do a lot to focus the community effort in making this thing really go!

@emxsys
Copy link
Contributor

emxsys commented Apr 6, 2019

@wcmatthysen I'm ready to move forward. I can create the WorldWindJava fork with issue tracker, and a "WorldWindJava" team within the WorldWindEarth GitHub organization.

@emxsys
Copy link
Contributor

emxsys commented Apr 6, 2019

For consideration: https://opensource.guide/leadership-and-governance/

@wcmatthysen
Copy link
Author

@emxsys Great, let's do it. I would love to help out where I can. I don't know exactly where I'll fit in, but I'd like to contribute some of my code and help with the ongoing maintenance of the code-base. Thanks for the link on the opensource leadership and governance.

@PJHogan
Copy link

PJHogan commented Apr 6, 2019

Wahoo!
WorldWind Java, WWJ, going from world-class to global-class!
Android can't be far behind!

@caller
Copy link

caller commented Apr 6, 2019

Hi Patrick,

Just to clarify: nasa will host tile servers but they will probably stop writing new code. Is that a correct summary?

I have seen some NASA ESA collaborations on WW over the years. Do you know the status of the ESA engagement?

Thx Marco

@PJHogan
Copy link

PJHogan commented Apr 6, 2019

Marco, I can only read the tea leaves, but my sense is that NASA got a wake-up call and so will continue to develop WorldWind, particularly the web version, especially given ESA has been coordinating with NASA on that development for a few years now. And the ESA contribution has been HUGE!

Unfortunately, the NASA 'official' numbered releases have been quite slow-on-the-draw (branches of the repository have many capabilities waiting for an 'official' release). FORTUNATELY https://worldwind.earth/ incorporates these, along with other 'select' contributions and bug fixes from the community.

And I believe the ESA Copernicus Sentinel apps are also pulling from there:
https://itunes.apple.com/us/app/copernicus-sentinel/id1036738151
https://play.google.com/store/apps/details?id=it.acsys.android.esaersapp

So, my reading is that the ESA+NASA joint effort will continue.
But if you want the best of that, now and to come, it's here,
https://github.com/WorldWindEarth/

@caller
Copy link

caller commented Apr 7, 2019

Thx Patrick,
So we should still go full speed ahead on the java and android side with our community approach. 😊

@PJHogan
Copy link

PJHogan commented Apr 7, 2019

Virtual globe technology is essential to so much operational and infrastructure management, as well as Earth status, scientific and other. This open source platform has much to offer the world, not only in terms of support, but also facilitating both the opportunity for innovation and the sharing of solutions. WorldWind is the epitome of an essential software technology 'for the benefit of all.'
Thanks for your contribution of this wonderful gift to the world!

@wcmatthysen
Copy link
Author

Just a heads-up to anyone that comes across this:

The community-fork of WorldWindJava has been created at: https://github.com/WorldWindEarth/WorldWindJava
thanks to Bruce (@emxsys).

Please feel free join in and contribute. We need all the help we can get to make this a success.

@quonn77
Copy link

quonn77 commented Apr 8, 2019 via email

@wcmatthysen
Copy link
Author

Yes, as far as I understand the develop branch is the latest unstable branch where development happens. You create a new branch that branches off from the develop branch when developing a new feature (ideally with a short name that describes the feature). Then, when the feature is ready the pull request is merged back into the develop branch. From time to time the develop branch gets merged into master when a stable release is made.

@Beak-man
Copy link
Member

Beak-man commented Sep 3, 2019

Hello all,
Fortunately, WorldWind has received renewed commitment from NASA for continued development and support.
More information in the project's website:
https://worldwind.arc.nasa.gov/news/2019-08-21-project-update/

@wcmatthysen
Copy link
Author

wcmatthysen commented Sep 4, 2019

@Beak-man, are the WorldWind developers at least going to try and work with the open-source community this time? Because last time I checked, and if I can quote @pdavidc on this, the policy was:

It's also worth noting that NASA World Wind is an open source project, but is closed development. Our NASA administrator can provide more insight into this if you'd like. We accept pull requests sparingly.

That didn't really inspire a community to become involved in this project to be frank. But hey, that is just my 2-cents on this.

Also, you might have a look at what we did over at the community-edition. We managed to fix a lot of outstanding issues that were never addressed here. Will you actually merge in those changes, or are you going to re-commit the changes as your own like @zglueck did in this pull-request?

@Beak-man
Copy link
Member

Beak-man commented Sep 4, 2019

@wcmatthysen , officially speaking, the point of contact to address such inquiries can be found here.

I'll tell you what I would personally like, though: Setting up the project in a similar way to this one (particularly the part about NASA's CLA) in order to improve our engagement with the open source community, which of course is part of our developer community. I'll bring it up with management and we'll see how it goes from there.

@PJHogan
Copy link

PJHogan commented Sep 7, 2019

Let's allow the FUTURE tohappen!
Get this planet onto one page for spatial data!
Come on NASA and community!
Please find a way to get it together 'for the benefit of all.'

@wcmatthysen
Copy link
Author

@Beak-man, @PJHogan, I'm going to be honest and say that I'm a bit pessimistic about this "renewed commitment" from NASA given the history of how the WorldWind devs managed this repository. I can already see a pull-request with work being done that has already being done by the community to some extent. The JOGL upgrade was done way back in 2016 by @xranby in pull-request #1. If you are sincere with regards to getting a community involved in this project you need to interact with them. You could start by merging some of the outstanding pull-requests that should have been pulled in a long time ago. Those stale pull-requests are just sitting there cluttering up the repository and it gives the impression that contributions are not accepted by the developers of this repository. But, from what I've seen how this repository was managed, it looks like you are going to run this again as an exclusive club where only the WorldWind devs interact with one another. Hopefully I'm wrong and you guys can rebuild a community. I just get the feeling that most of the community have already left and moved on.

@PJHogan
Copy link

PJHogan commented Sep 7, 2019

@wcmatthysen You are quite accurate in your concern!

And thanks dearly for your incredible support over the years. This repository certainly deserves the kind of respect you so accurately describe as lacking.

It will be interesting to see if NASA can finally rise to the occasion.

@markpet49
Copy link
Member

@wcmatthysen Thanks for the feedback. A couple of points. 1. You should raise your concerns to the project management folks, they can be reached via the contact page on the web site. The people who respond to you here don't make the decisions about project direction. 2. We will be reviewing the old PRs as we work on the WWJ code. PR #1 is likely invalid as we're working with the new unreleased JOGL code (last modified on Sept 4 or so.) so as to be Java 11+ compatible.

@markpet49
Copy link
Member

@wcmatthysen A third point. The NASA version of WorldWind has to be curated in a way that makes certain government agencies comfortable with using the software. That being said, I'm hearing positive noises from project management regarding community engagement. Unfortunately, only time will tell if your pessimism is justified or not.

@DJViking
Copy link

DJViking commented Aug 13, 2020

NASA WorldWind just got new releases for Java and Web.

Web WorldWind 0.10.0 and WorldWind Java 2.2.0 are now available on GitHub. The new version of Web WorldWind addresses potential vulnerabilities in the code and underlying packages. The new version of WorldWind Java focuses on upgrading to Java 11 and JOGL 2.4 as well as a switch to Apache 2.0 license. WorldWind’s API remains largely unchanged in this release and we are committed to maintaining a consistent API in future releases. More information on the release can be found at these links: Web WorldWind 0.10.0 and WorldWind Java 2.2.0.

Please direct questions to our new email address: arc-worldwind@mail.nasa.gov.

The news article on the shutdown seems to have been removed
https://worldwind.arc.nasa.gov/news/...ension-notice/

Instead there is now an news article that says NASA has recommitted to WorldWind
https://worldwind.arc.nasa.gov/news/...roject-update/

Does not look like the community fork is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests