Code coverage using coveralls #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viklund
force-pushed
the
feature/code-coverage
branch
from
a5adb58
to
902c171
Compare
kusalananda
approved these changes
Apr 5, 2018
test/travis_script.sh
Outdated
| ../test/01_daemon_starts.sh | ||
| cd .. |
There was a problem hiding this comment.
Use (cd backend && ../test/01_daemon_starts.sh) instead of changing directory back and forth.
test/travis_script.sh
Outdated
| BACKEND_PID=$! | ||
|
|
||
| sleep 2 # Lets wait a little bit so the server has started | ||
|
|
||
| function exit_handler() { |
There was a problem hiding this comment.
Drop the function keyword form the function definition.
test/travis_script.sh
Outdated
| function exit_handler() { | ||
| rv=$? | ||
| # Ignore errors in the exit handler | ||
| set +e | ||
| kill -9 $BACKEND_PID |
There was a problem hiding this comment.
Does it work with a plain kill? kill -9 is not nice, but it may not matter much here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.