Feature/compute callcount #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinAhlberg
commented
Apr 17, 2019
MalinAhlberg
force-pushed
the
feature/compute_callcount
branch
from
0f03bbd
to
38c1604
Compare
Assuming the vcf files are properly ordered (by increasing position). TODO: better error handling.
MalinAhlberg
force-pushed
the
feature/compute_callcount
branch
from
38c1604
to
17f94d1
Compare
talavis
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Move the calculation of callcount from psql to python import (
--count_calls) This speeds up queries to the beacon metadata, which no longer needs to be materialized.Also improve the sql schema so that no views are materialized.
Changes made:
data_tablea real table