avoid exceptions when a non-existing gene is requested #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viklund
approved these changes
May 16, 2019
| variants = list(map(format_variant, variants)) | ||
| if variants: | ||
| for variant in variants: | ||
| if datatype in ('gene', 'transcript'): |
There was a problem hiding this comment.
I know this is not what was focused on in the PR, but this if statement seems superflous to me. Wouldn't it be better with this approximate structure:
anno = None
if datatype == 'transcript':
# ...
elif datatype == 'gene':
# ...
if anno:
variant['vep_annotations'] = annoThis code is too complex in general, it needs to be simplified somehow but I don't know quite how at the moment. Maybe a solution is to have different classes for gene, region and transcript and dispatch based on that. Not now though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Handle a couple of situations where a non-existing gene is requested.