Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object type for coverage #575

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Fix object type for coverage #575

merged 1 commit into from
Jun 26, 2019

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Jun 26, 2019

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Make sure a usable object is returned from get_coverage_for_bases().

MalinAhlberg
MalinAhlberg approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using list() would be more intuitive than doing a list comprehension?

@talavis talavis merged commit 17f8252 into develop Jun 26, 2019
@talavis talavis deleted the bugfix/region-coverage branch June 26, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalinAhlberg MalinAhlberg MalinAhlberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talavis @MalinAhlberg