Allow use of new ocean mask variable default #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stats. Also add a new adf defaults "mask" variable that should easily enable a user to apply the ocean mask to the quantities of their choosing.
nusbaume
changed the title
nusbaume
changed the title
nusbaume
added
enhancement
justin-richling
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
mask: "ocean"option to the ADF variable defaults list that allows a user to have only values over the open ocean included in table calculations and plot generation, except for (currently) the special regional map generation. This new mask is applied by default toSST, but can always be added to additional variables as well by default later.Also, there are currently no "observations" of ocean fraction in the ADF observations collection, and thus for now the mask is only applied for model vs. model comparisons
Finally, it should be noted that in order for this new feature to be applied properly, the provided conda environment had to be updated, which brings the ADF environment closer in line with CISL's NPL envrionment. This modification will also require a new ADF tag to be made after this PR is merged, so that a user can easily find the exact conda environment file they need.
Along with the mask addition, a bug was fixed in the calculation of climo files.
Fixes #190
Fixes #193
Fixes #214
Addresses #157