Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Pass/fail test for ran_unif #499

Closed
hkershaw-brown opened this issue Jun 23, 2023 · 0 comments · Fixed by #549
Closed

Feature request: Pass/fail test for ran_unif #499

hkershaw-brown opened this issue Jun 23, 2023 · 0 comments · Fixed by #549
Assignees
Labels
back burner very low priority. Future work? psi possible student issue

Comments

@hkershaw-brown
Copy link
Member

Use case

Recently we had a problem with perturb from single instance using the cce compiler (cce/15.0.1): #495
Digging into the problem we found that the ran_unif was not giving the expected results.
Our current random_sequence tests require a human to look at the output for 'correct' answers. It would be better to have a pass/fail test we can automate.

Is your feature request related to a problem?

yes see #495

Describe your preferred solution

ran_unif is using Mersenne Twister.
Run ran_unif with a known seed, compare the integers produced against a reference solution for the Mersenne Twister

Describe any alternatives you have considered

You could test the boz constants (see #495 boz_dart.f90) without needing to compile any dart code.
However, this won't catch other problems with the random number generator.

@hkershaw-brown hkershaw-brown added the back burner very low priority. Future work? label Jun 26, 2023
@hkershaw-brown hkershaw-brown added the psi possible student issue label Aug 23, 2023
c-merchant added a commit to c-merchant/DART that referenced this issue Sep 26, 2023
hkershaw-brown added a commit that referenced this issue Oct 5, 2023
ran_unif Mersenne twister test: Resolution to Issue #499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back burner very low priority. Future work? psi possible student issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants