Brand new lsp #11
Merged
Brand new lsp #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has one major change and one minor change.
The major change is to use a
std::vector<size_t>and astd::vector<bool>to represent theLSPlist. This change addresses #7 .(It brings more than 10% speed improvement.)
The minor change is to put all coefficient refinement operations into the
refinement_pass, eliminating the use of vectorm_indices_to_refine. This change should save substantial amount of memory in high BPP cases.(It reduces peak memory from 8.4GB to 6.7GB in one case.)