Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double input does not allow small values in normal mode #2934

Closed
StasJ opened this issue Dec 14, 2021 · 7 comments · Fixed by #2956
Closed

Double input does not allow small values in normal mode #2934

StasJ opened this issue Dec 14, 2021 · 7 comments · Fixed by #2956

Comments

@StasJ
Copy link
Collaborator

StasJ commented Dec 14, 2021

  1. Pick a double input that maps to a params value.
  2. Add a print statement to observe that params value.

With that input:

  1. Set the mapping range input to scientific notation mode
  2. Input 1e-20

Notice that params are set to 1e-20

  1. Set the mapping range input to normal mode
  2. Input 1e-20

Notice that params are set to 0

@StasJ StasJ added the Bug label Dec 14, 2021
@sgpearse sgpearse added the High label Dec 14, 2021
@sgpearse sgpearse added this to the 3_6_0 Release milestone Dec 14, 2021
@sgpearse sgpearse self-assigned this Dec 14, 2021
@sgpearse
Copy link
Collaborator

The read value displayed and read from the gui should only reflect what's in the Params database.

IE - toggling scientific notation should only affect what's displayed in the GUI, not in Params.

StasJ added a commit that referenced this issue Jan 5, 2022
@StasJ StasJ added the Fixed label Jan 5, 2022
clyne pushed a commit that referenced this issue Jan 6, 2022
@clyne
Copy link
Collaborator

clyne commented Jan 31, 2022

@StasJ I can't reproduce this to verify that it is fixed. There is not enough information. Please provide more detailed instructions

@StasJ
Copy link
Collaborator Author

StasJ commented Feb 1, 2022

@StasJ I can't reproduce this to verify that it is fixed. There is not enough information. Please provide more detailed instructions

I updated the instructions.

@sgpearse
Copy link
Collaborator

When I add

std::cout << std::scientific << "value " << value << std::endl;

To PDoubleInput.cpp:16, I still get 0.000000e+00 when entering 1e-20 to the Slice Rotation X component.

@sgpearse sgpearse reopened this Feb 11, 2022
@clyne
Copy link
Collaborator

clyne commented Feb 14, 2022

@StasJ need more guidance on how to verify if this is indeed fixed.

@sgpearse
Copy link
Collaborator

sgpearse commented Feb 14, 2022

@StasJ A WRF file for reproducing this can be found here.

@StasJ
Copy link
Collaborator Author

StasJ commented Feb 15, 2022

@sgpearse The widget you picked does not use PDoubleInput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants