Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Particle Lighting seems weird #3214 #3490

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix Particle Lighting seems weird #3214 #3490

merged 1 commit into from
Dec 5, 2023

Conversation

StasJ
Copy link
Collaborator

@StasJ StasJ commented Nov 3, 2023

Fix #3214

@shaomeng
Copy link
Contributor

shaomeng commented Nov 28, 2023 •
edited
Loading

This PR changes the behavior of the lighting, but I wouldn't say it moves in the right direction.
Specifically, regarding the two issues reported in #3214 ,

  1. the specular lighting remains the same
  2. the Shineness is not improved, but changed to appear more like fuzziness.

@sgpearse sgpearse merged commit fc5e86f into main Dec 5, 2023
3 checks passed
@StasJ StasJ deleted the issue3214 branch July 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaomeng shaomeng shaomeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Particle Lighting seems weird.
3 participants
@StasJ @shaomeng @sgpearse